From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5DB881FF15C for ; Fri, 28 Nov 2025 15:56:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8CD6F1D9D8; Fri, 28 Nov 2025 15:56:59 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 28 Nov 2025 15:56:11 +0100 Message-ID: <20251128145622.163185-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764341747034 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] qmp client: bump timeout for synchronous blockdev snapshot commands to 1 hour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" It's a commonly reported issue, most recently again in the enterprise support, that taking or removing snapshots of large qcow2 files on file-based network storages runs into a timeout. If the timeout is hit, that just means additional manual steps to clean up afterwards for users. The synchronous QMP command will still be blocking the main thread of the QEMU instance until it has run to completion. Therefore, a longer timeout does not really hurt here, while reducing the number of times the aforementioned cleanup is necessary. In the long term, using snapshot-as-volume-chain should be a good alternative for such cases, once it's deemed production-ready. Signed-off-by: Fiona Ebner --- src/PVE/QMPClient.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/PVE/QMPClient.pm b/src/PVE/QMPClient.pm index e4f7a515..c3ed0e32 100644 --- a/src/PVE/QMPClient.pm +++ b/src/PVE/QMPClient.pm @@ -132,8 +132,6 @@ sub cmd { $cmd->{execute} eq 'backup-cancel' || $cmd->{execute} eq 'blockdev-del' || $cmd->{execute} eq 'blockdev-mirror' - || $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync' - || $cmd->{execute} eq 'blockdev-snapshot-internal-sync' || $cmd->{execute} eq 'block-job-cancel' || $cmd->{execute} eq 'block-job-complete' || $cmd->{execute} eq 'drive-mirror' @@ -146,6 +144,11 @@ sub cmd { || $cmd->{execute} eq 'savevm-start' ) { $timeout = 10 * 60; # 10 mins + } elsif ( + $cmd->{execute} eq 'blockdev-snapshot-delete-internal-sync' + || $cmd->{execute} eq 'blockdev-snapshot-internal-sync' + ) { + $timeout = 60 * 60; # 1 hour } else { # NOTE: if you came here as user and want to change this, try using IO-Threads first # which move out quite some processing of the main thread, leaving more time for QMP -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel