From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 37D4B1FF179 for ; Wed, 26 Nov 2025 19:15:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9AC92137D7; Wed, 26 Nov 2025 19:15:59 +0100 (CET) Date: Wed, 26 Nov 2025 19:15:55 +0100 From: Stoiko Ivanov To: Thomas Lamprecht Message-ID: <20251126191555.3e944519@rosa.proxmox.com> In-Reply-To: <5482904f-efa5-40ef-b8e6-f1ba935f2431@proxmox.com> References: <20251118151532.592423-1-s.ivanov@proxmox.com> <20251118151532.592423-2-s.ivanov@proxmox.com> <5482904f-efa5-40ef-b8e6-f1ba935f2431@proxmox.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764180918567 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.072 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH installer 1/2] common: pinning: require first character to be lower-case ascii X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Tue, 25 Nov 2025 07:54:52 +0100 Thomas Lamprecht wrote: > Am 18.11.25 um 16:15 schrieb Stoiko Ivanov: > > the validation regex in pve-common is: > > `/^[a-z][a-z0-9_]{1,20}([:\.]\d+)?$/` [0] > > Recently re-checked this patch, as when adding some tests for this, the > behavior of allowing uppercase characters for all but the first one > seemed strange given above regex. > > But this isn't the real regex though, as that would require all lowercase, > not just the first character. The real regex as linked by [0] has a > case-insensitive flag applied, so the case limitations of your patch suggest > are overly strict compared to what pve-common accepts. > It can be fine to be a bit more restrictive here, but lets not justificate > doing so with a wrongly quoted validation regex. > Thanks for catching this! as my previous attempts at getting this in sync with what pve-common does always missed something (and/or followed my gut-feeling more than what the code in pve-common actually does) - I copied the validation from pve-common: https://lore.proxmox.com/pve-devel/20251126180819.817240-1-s.ivanov@proxmox.com/T/#t _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel