From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 55F4A1FF15E for ; Mon, 24 Nov 2025 13:22:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D890218F8; Mon, 24 Nov 2025 13:22:30 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 24 Nov 2025 13:21:51 +0100 Message-ID: <20251124122223.358353-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763986911231 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, blockdev.pm] Subject: [pve-devel] [PATCH qemu-server] blockdev: add NBD: fix handling of IPv6 host to unbreak TCP disk live migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As reported in the community forum [0], live disk migration using migration type 'insecure' would fail when the target is an IPv6 host. When passing the IPv6 address to QMP, the surrounding square brackets need to be removed first. [0]: https://forum.proxmox.com/threads/176727/ Fixes: 3fee3186 ("blockdev: add support for NBD paths") Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/Blockdev.pm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer/Blockdev.pm b/src/PVE/QemuServer/Blockdev.pm index 26e9c383..af7e769b 100644 --- a/src/PVE/QemuServer/Blockdev.pm +++ b/src/PVE/QemuServer/Blockdev.pm @@ -274,8 +274,13 @@ my sub generate_file_blockdev { my $server = { type => 'unix', path => "$1" }; $blockdev = { driver => 'nbd', server => $server, export => "$2" }; } elsif ($drive->{file} =~ m/^$NBD_TCP_PATH_RE_3$/) { - my $server = { type => 'inet', host => "$1", port => "$2" }; # port is also a string in QAPI - $blockdev = { driver => 'nbd', server => $server, export => "$3" }; + my ($host, $port, $export) = ($1, $2, $3); + if ($host =~ m/^\[(.*)\]$/) { # IPv6 address needs to be passed without square brackets + $host = $1; + } + # port is also a string in QAPI + my $server = { type => 'inet', host => "$host", port => "$port" }; + $blockdev = { driver => 'nbd', server => $server, export => "$export" }; } elsif ($drive->{file} eq 'cdrom') { my $path = PVE::QemuServer::Drive::get_iso_path($storecfg, $drive->{file}); $blockdev = { driver => 'host_cdrom', filename => "$path" }; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel