From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7AFD41FF183 for ; Wed, 19 Nov 2025 13:57:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8859B84DF; Wed, 19 Nov 2025 13:57:54 +0100 (CET) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Wed, 19 Nov 2025 13:57:10 +0100 Message-ID: <20251119125711.165181-2-s.shaji@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251119125711.165181-1-s.shaji@proxmox.com> References: <20251119125711.165181-1-s.shaji@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763557009896 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.117 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve_flutter_frontend 1/2] fix #7045: regression: avoid system intrusion from navigation bar X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In the following commit(f263217) the `ColoredSafeArea` was removed. However the system intrusion from the system bottom navigation bar was causing issues. Inorder to fix the issue the wrap the body of the guest's overview and options page with `SafeArea` widget. For iOS set the bottom padding to false as it feels like there is a background present under the bottom navigation indicator. Signed-off-by: Shan Shaji --- lib/widgets/pve_config_list_tile.dart | 5 +++-- lib/widgets/pve_lxc_options_widget.dart | 8 ++++++-- lib/widgets/pve_lxc_overview.dart | 8 ++++++-- lib/widgets/pve_node_overview.dart | 8 ++++++-- lib/widgets/pve_qemu_options_widget.dart | 8 ++++++-- lib/widgets/pve_qemu_overview.dart | 10 +++++++--- 6 files changed, 34 insertions(+), 13 deletions(-) diff --git a/lib/widgets/pve_config_list_tile.dart b/lib/widgets/pve_config_list_tile.dart index 712ff1a..c937755 100644 --- a/lib/widgets/pve_config_list_tile.dart +++ b/lib/widgets/pve_config_list_tile.dart @@ -130,7 +130,8 @@ class _PveConfigEditorFormState extends State<_PveConfigEditorForm> { @override Widget build(BuildContext context) { - return Container( + return SafeArea( + child: Container( padding: const EdgeInsets.symmetric(horizontal: 12), child: Column( mainAxisSize: MainAxisSize.min, @@ -164,6 +165,6 @@ class _PveConfigEditorFormState extends State<_PveConfigEditorForm> { const SizedBox(height: 8), ], ), - ); + ),); } } diff --git a/lib/widgets/pve_lxc_options_widget.dart b/lib/widgets/pve_lxc_options_widget.dart index 4bd263e..21398d2 100644 --- a/lib/widgets/pve_lxc_options_widget.dart +++ b/lib/widgets/pve_lxc_options_widget.dart @@ -1,3 +1,5 @@ +import 'dart:io'; + import 'package:flutter/material.dart'; import 'package:pve_flutter_frontend/bloc/pve_lxc_overview_bloc.dart'; import 'package:pve_flutter_frontend/states/pve_lxc_overview_state.dart'; @@ -18,7 +20,9 @@ class PveLxcOptions extends StatelessWidget { if (config != null) { return Scaffold( appBar: AppBar(), - body: SingleChildScrollView( + body: SafeArea( + bottom: !Platform.isIOS, + child: SingleChildScrollView( child: Column( children: [ ListTile( @@ -114,7 +118,7 @@ class PveLxcOptions extends StatelessWidget { ], ), ), - ); + ),); } return const Center( child: CircularProgressIndicator(), diff --git a/lib/widgets/pve_lxc_overview.dart b/lib/widgets/pve_lxc_overview.dart index 1148452..0f486d2 100644 --- a/lib/widgets/pve_lxc_overview.dart +++ b/lib/widgets/pve_lxc_overview.dart @@ -1,3 +1,5 @@ +import 'dart:io'; + import 'package:flutter/material.dart'; import 'package:font_awesome_flutter/font_awesome_flutter.dart'; import 'package:provider/provider.dart'; @@ -75,7 +77,9 @@ class PveLxcOverview extends StatelessWidget { title: Text(config?.hostname ?? 'CT $guestID'), ), backgroundColor: Theme.of(context).colorScheme.surfaceContainer, - body: SingleChildScrollView( + body: SafeArea( + bottom: !Platform.isIOS, + child: SingleChildScrollView( child: Column( children: [ PveGuestOverviewHeader( @@ -258,7 +262,7 @@ class PveLxcOverview extends StatelessWidget { ], ), ), - ); + ),); }), ); } diff --git a/lib/widgets/pve_node_overview.dart b/lib/widgets/pve_node_overview.dart index f99ca53..f0583a3 100644 --- a/lib/widgets/pve_node_overview.dart +++ b/lib/widgets/pve_node_overview.dart @@ -1,3 +1,5 @@ +import 'dart:io'; + import 'package:flutter/material.dart'; import 'package:font_awesome_flutter/font_awesome_flutter.dart'; import 'package:provider/provider.dart'; @@ -60,7 +62,9 @@ class PveNodeOverview extends StatelessWidget { ), ), backgroundColor: Theme.of(context).colorScheme.surfaceContainer, - body: SingleChildScrollView( + body: SafeArea( + bottom: !Platform.isIOS, + child: SingleChildScrollView( child: Column( children: [ if (rrd.isNotEmpty) @@ -442,7 +446,7 @@ class PveNodeOverview extends StatelessWidget { ], ), ), - ); + ),); }, ); } diff --git a/lib/widgets/pve_qemu_options_widget.dart b/lib/widgets/pve_qemu_options_widget.dart index f8cb000..0f0d46a 100644 --- a/lib/widgets/pve_qemu_options_widget.dart +++ b/lib/widgets/pve_qemu_options_widget.dart @@ -1,3 +1,5 @@ +import 'dart:io'; + import 'package:flutter/material.dart'; import 'package:provider/provider.dart'; import 'package:pve_flutter_frontend/bloc/pve_qemu_overview_bloc.dart'; @@ -26,7 +28,9 @@ class PveQemuOptions extends StatelessWidget { onPressed: () => Navigator.of(context).pop(), ), ), - body: SingleChildScrollView( + body: SafeArea( + bottom: !Platform.isIOS, + child: SingleChildScrollView( child: Form( key: _formKey, onChanged: () {}, @@ -207,7 +211,7 @@ class PveQemuOptions extends StatelessWidget { ), ), ), - ); + ),); } return const Center( child: CircularProgressIndicator(), diff --git a/lib/widgets/pve_qemu_overview.dart b/lib/widgets/pve_qemu_overview.dart index 15ab409..a80a58a 100644 --- a/lib/widgets/pve_qemu_overview.dart +++ b/lib/widgets/pve_qemu_overview.dart @@ -1,3 +1,5 @@ +import 'dart:io'; + import 'package:flutter/material.dart'; import 'package:font_awesome_flutter/font_awesome_flutter.dart'; import 'package:provider/provider.dart'; @@ -76,8 +78,10 @@ class PveQemuOverview extends StatelessWidget { title: Text(config?.name ?? 'VM $guestID'), ), backgroundColor: Theme.of(context).colorScheme.surfaceContainer, - body: SingleChildScrollView( - child: Column( + body: SafeArea( + bottom: !Platform.isIOS, + child: SingleChildScrollView( + child: Column( children: [ PveGuestOverviewHeader( background: !(status?.template ?? false) @@ -242,7 +246,7 @@ class PveQemuOverview extends StatelessWidget { ]), ], )), - ); + ),); }), ); } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel