From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6A6681FF187 for ; Tue, 18 Nov 2025 16:16:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AB6F818709; Tue, 18 Nov 2025 16:16:11 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 18 Nov 2025 16:15:27 +0100 Message-ID: <20251118151532.592423-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251118151532.592423-1-s.ivanov@proxmox.com> References: <20251118151532.592423-1-s.ivanov@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763478908078 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [validate-link-pin-map.pl, net.pm] Subject: [pve-devel] [PATCH installer 2/2] sys: net: fix error-message for interface names first character X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This follows the similar commit for the TUI installer, but as the validation here was in accordance to the one in pve-common, only adapts the error-message (and affected test-cases). Fixes: 2033a35 ("sys: net: pinning: make interface name checks stricter") Reported-by: Robert Obkircher Signed-off-by: Stoiko Ivanov --- Proxmox/Sys/Net.pm | 2 +- test/validate-link-pin-map.pl | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Proxmox/Sys/Net.pm b/Proxmox/Sys/Net.pm index f6a0940..37feee1 100644 --- a/Proxmox/Sys/Net.pm +++ b/Proxmox/Sys/Net.pm @@ -341,7 +341,7 @@ sub validate_link_pin_map : prototype($) { } if ($name !~ m/^[a-z]/) { - die "interface name '$name' for '$mac' is invalid: name must start with a letter\n"; + die "interface name '$name' for '$mac' is invalid: name must start with a lower-case letter\n"; } if ($name !~ m/^[a-zA-Z_][a-zA-Z0-9_]*$/) { diff --git a/test/validate-link-pin-map.pl b/test/validate-link-pin-map.pl index 3a95aab..3fbd0e4 100755 --- a/test/validate-link-pin-map.pl +++ b/test/validate-link-pin-map.pl @@ -45,14 +45,14 @@ is( eval { validate_link_pin_map({ 'ab:cd:ef:12:34:56' => '0nic' }) }; is( $@, - "interface name '0nic' for 'ab:cd:ef:12:34:56' is invalid: name must start with a letter\n", + "interface name '0nic' for 'ab:cd:ef:12:34:56' is invalid: name must start with a lower-case letter\n", "name starting with number is rejected", ); eval { validate_link_pin_map({ 'ab:cd:ef:12:34:56' => '_a' }) }; is( $@, - "interface name '_a' for 'ab:cd:ef:12:34:56' is invalid: name must start with a letter\n", + "interface name '_a' for 'ab:cd:ef:12:34:56' is invalid: name must start with a lower-case letter\n", "name starting with underscore is rejected", ); -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel