From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DFEBF1FF185 for ; Mon, 17 Nov 2025 17:28:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2F1CE1F309; Mon, 17 Nov 2025 17:28:33 +0100 (CET) From: Markus Frank To: pve-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 17:26:44 +0100 Message-ID: <20251117162819.465530-2-m.frank@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251117162819.465530-1-m.frank@proxmox.com> References: <20251117162819.465530-1-m.frank@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763396880531 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v1 1/3] vga: allow live-migration with clipboard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The live-migration feature now works with qemu's upstream commit: 5d56bff11e ("ui/vdagent: add migration support") Signed-off-by: Markus Frank --- src/PVE/API2/Qemu.pm | 5 ----- src/PVE/QemuMigrate.pm | 5 ----- src/PVE/QemuServer.pm | 2 +- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm index 02f5caec..314b6a48 100644 --- a/src/PVE/API2/Qemu.pm +++ b/src/PVE/API2/Qemu.pm @@ -5267,11 +5267,6 @@ __PACKAGE__->register_method({ my ($local_resources, $mapped_resources, $missing_mappings_by_node) = PVE::QemuMigrate::Helpers::check_local_resources($vmconf, $res->{running}, 1); - my $vga = PVE::QemuServer::parse_vga($vmconf->{vga}); - if ($res->{running} && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') { - push $local_resources->@*, "clipboard=vnc"; - } - $res->{allowed_nodes} = []; $res->{not_allowed_nodes} = {}; diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index 6f7fd9f1..4f613ffb 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -293,11 +293,6 @@ sub prepare { } } - my $vga = PVE::QemuServer::parse_vga($conf->{vga}); - if ($running && $vga->{'clipboard'} && $vga->{'clipboard'} eq 'vnc') { - die "VMs with 'clipboard' set to 'vnc' are not live migratable!\n"; - } - my $vollist = PVE::QemuServer::get_vm_volumes($conf); my $storages = {}; diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 1b9257ef..6d33bec0 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -184,7 +184,7 @@ my $vga_fmt = { clipboard => { description => 'Enable a specific clipboard. If not set, depending on the display type the' - . ' SPICE one will be added. Migration with VNC clipboard is not yet supported!', + . ' SPICE one will be added.', type => 'string', enum => ['vnc'], optional => 1, -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel