From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D3C551FF185 for ; Mon, 17 Nov 2025 14:19:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12D68193D3; Mon, 17 Nov 2025 14:19:48 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 14:18:50 +0100 Message-ID: <20251117131945.2148025-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, info.name] Subject: [pve-devel] [PATCH manager] ui: resource tree: fix rendering of guest text when sorted by name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" In a recent commit, we changed how we render the text for element in the resource tree, namely by not overwriting the original data in the store. During that code move & change, a bug slipped in, where we correctly detected that we're sorting by name and set the text to the correct format, but ultimately discarded that value and overwrote it with the original one from the store. Fix this by first extracting the original text from the record, and the use the text like we did the record field before This was reported in the forum: https://forum.proxmox.com/threads/176021/ Fixes: 83783c3b (ui: resource tree: prevent overwriting of 'text' property) Signed-off-by: Dominik Csapak --- i hope this is the last fix i have to do for the tree rendering in a long time ;) www/manager6/tree/ResourceTree.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js index 770f7555..29e098d8 100644 --- a/www/manager6/tree/ResourceTree.js +++ b/www/manager6/tree/ResourceTree.js @@ -54,7 +54,7 @@ Ext.define('PVE.tree.ResourceTree', { renderer: function (val, meta, rec) { let info = rec.data; - let text = ''; + let text = info.text; let status = ''; if (info.type === 'storage') { let usage = info.disk / info.maxdisk; @@ -72,7 +72,7 @@ Ext.define('PVE.tree.ResourceTree', { text = `${info.name} (${String(info.vmid)})`; } } - text = `${status}${info.text}`; + text = `${status}${text}`; text += PVE.Utils.renderTags(info.tags, PVE.UIOptions.tagOverrides); return (info.renderedText = text); }, -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel