From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 232741FF185 for ; Mon, 17 Nov 2025 12:52:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 28DB115E96; Mon, 17 Nov 2025 12:52:35 +0100 (CET) From: Robert Obkircher To: pve-devel@lists.proxmox.com Date: Mon, 17 Nov 2025 12:51:29 +0100 Message-ID: <20251117115148.58282-2-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251117115148.58282-1-r.obkircher@proxmox.com> References: <20251117115148.58282-1-r.obkircher@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763380323095 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v5 pve-container 1/5] Ensure that container startup warnings are displayed if startup fails. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" During container startup, warnings are written to a file, which is later logged to the RESTEnvironment. This should also happen in the presence of errors, so move it outside the eval block. Signed-off-by: Robert Obkircher --- src/PVE/LXC.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index e6b0f50..dd16215 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -3169,10 +3169,10 @@ sub vm_start { # if debug is requested, print the log it also when the start succeeded print_ct_stderr_log($vmid) if $is_debug; - - print_ct_warn_log($vmid); # always print warn log, if any }; - if (my $err = $@) { + my $err = $@; + print_ct_warn_log($vmid); # always print warn log, if any + if ($err) { unlink $skiplock_flag_fn; die $err; } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel