From: Robert Obkircher <r.obkircher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v4 pve-container 1/5] Ensure that container startup warnings are displayed if startup fails.
Date: Thu, 13 Nov 2025 16:02:59 +0100 [thread overview]
Message-ID: <20251113150342.101933-2-r.obkircher@proxmox.com> (raw)
In-Reply-To: <20251113150342.101933-1-r.obkircher@proxmox.com>
During container startup, warnings are written to a file, which is
later logged to the RESTEnvironment. This should also happen in the
presence of errors, so move it outside the eval block.
Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
---
src/PVE/LXC.pm | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 89ccb54..44e20bc 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2976,10 +2976,12 @@ sub vm_start {
# if debug is requested, print the log it also when the start succeeded
print_ct_stderr_log($vmid) if $is_debug;
-
+ };
+ my $err = $@;
+ eval {
print_ct_warn_log($vmid); # always print warn log, if any
};
- if (my $err = $@) {
+ if ($err) {
unlink $skiplock_flag_fn;
die $err;
}
--
2.47.3
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-13 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 15:02 [pve-devel] [PATCH v4 pve-container 0/5] warn that nesting may be required Robert Obkircher
2025-11-13 15:02 ` Robert Obkircher [this message]
2025-11-13 16:14 ` [pve-devel] [PATCH v4 pve-container 1/5] Ensure that container startup warnings are displayed if startup fails Fiona Ebner
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 2/5] Propagate prestart-hook warnings to task-log Robert Obkircher
2025-11-13 16:36 ` Fiona Ebner
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 3/5] fix #6897: warn that nesting may be required for systemd Robert Obkircher
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 4/5] fix #6897: constrain and untaint path for systemd version detection Robert Obkircher
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 4/5] fix #6897: constrain and untaint path when detecting systemd version Robert Obkircher
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 5/5] fix #6897: also warn in the post_clone and post_create hooks Robert Obkircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251113150342.101933-2-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox