From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 113501FF17E for ; Thu, 13 Nov 2025 16:03:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E5317201D5; Thu, 13 Nov 2025 16:04:30 +0100 (CET) From: Robert Obkircher To: pve-devel@lists.proxmox.com Date: Thu, 13 Nov 2025 16:02:58 +0100 Message-ID: <20251113150342.101933-1-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763046241328 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.500 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [plugin.pm] Subject: [pve-devel] [PATCH v4 pve-container 0/5] warn that nesting may be required X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This patch adds a task-log warning on CT start if systemd is detected. Changes since v3: - split and reordered the first 3 commits - constrain and untaint the objdump path - also warn in post_clone and post_create Changes since v2: - read $@ before new eval to preserve error - remove trailing whitespace Changes since v1: - increase minimum systemd version to something more reasonable - introduce helper callback to log warinings - replace RESTEnvironmnet::log_warn in setup plugins - syntactic changes: - renamed get_may_require_nesting_warning to check_systemd_nesting - use trailing if for return statements - call code from pre_start_hook as suggested Robert Obkircher (5): Ensure that container startup warnings are displayed if startup fails. Propagate prestart-hook warnings to task-log. fix #6897: warn that nesting may be required for systemd fix #6897: constrain and untaint path for systemd version detection fix #6897: also warn in the post_clone and post_create hooks src/PVE/LXC.pm | 6 ++++-- src/PVE/LXC/Setup.pm | 21 ++++++++++++++++++--- src/PVE/LXC/Setup/Base.pm | 30 ++++++++++++++++++++++++++++-- src/PVE/LXC/Setup/Debian.pm | 5 ++--- src/PVE/LXC/Setup/Plugin.pm | 2 +- src/PVE/LXC/Setup/Ubuntu.pm | 5 ++--- src/lxc-pve-prestart-hook | 24 +++++++++++------------- 7 files changed, 66 insertions(+), 27 deletions(-) -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel