From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6EAEC1FF17E for ; Thu, 13 Nov 2025 14:49:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D425E1CF17; Thu, 13 Nov 2025 14:50:35 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 13 Nov 2025 14:49:48 +0100 Message-ID: <20251113135023.1038305-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1763041805469 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer 0/6] interface name pinning followups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Some small followups for the initial name pinning support [0]. First and foremost makes the interface name checks a bit stricter, to comply with our `pve-iface` schema - as reported by Stoiko [1]. Thanks! Patch #4 & #5 exclude non-physical interfaces from being shown in the pinning dialog in the GUI and TUI, respectively. While this does change anything for normal bare-metal installation, it is a) a bit of future-proofing and b) improves developer/testing experience a bit, as these interfaces should never be available for pinning anyway. [0] https://lore.proxmox.com/pve-devel/20251111140014.1443471-1-c.heiss@proxmox.com/ [1] https://lore.proxmox.com/pve-devel/20251111181216.3c1ca6a0@rosa.proxmox.com/ Diffstat ======== Christoph Heiss (6): sys: net: pinning: make interface name checks stricter common: pinning: make interface name checks stricter test: validate-link-pin-map: give all tests a name gui: network: only display pinnable devices in pinning options dialog tui: network: only display pinnable devices in pinning options dialog tree-wide: run cargo fmt Proxmox/Install.pm | 9 +-- Proxmox/Install/RunEnv.pm | 12 ++- Proxmox/Sys/Net.pm | 35 +++------ proxinstall | 13 +++- .../src/bin/proxmox-auto-installer.rs | 7 +- proxmox-auto-installer/src/utils.rs | 15 ++-- .../src/fetch_plugins/http.rs | 7 +- .../src/fetch_plugins/partition.rs | 7 +- proxmox-installer-common/src/lib.rs | 7 +- proxmox-installer-common/src/options.rs | 77 ++++++++++++++----- proxmox-installer-common/src/setup.rs | 33 ++++---- proxmox-tui-installer/src/main.rs | 7 +- proxmox-tui-installer/src/views/network.rs | 33 +++++--- test/validate-link-pin-map.pl | 34 ++++++-- 14 files changed, 189 insertions(+), 107 deletions(-) -- 2.51.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel