[pve-devel] [PATCH firewall 1/1] firewall: set default value of NDP to 1 for nodes and guests

[pve-devel] [PATCH firewall 1/1] firewall: set default value of NDP to 1 for nodes and guests

[Michael Köppl]

The default value of 0 is incorrect, as by default, NDP is enabled for
both iptables and nftables. Change the default value to 1 to reflect
that.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 src/PVE/Firewall.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
index ec9c9ae..93f8c34 100644
--- a/src/PVE/Firewall.pm
+++ b/src/PVE/Firewall.pm
@@ -1404,7 +1404,7 @@ our $host_option_properties = {
     ndp => {
         description => "Enable NDP (Neighbor Discovery Protocol).",
         type => 'boolean',
-        default => 0,
+        default => 1,
         optional => 1,
     },
     nf_conntrack_allow_invalid => {
@@ -1475,7 +1475,7 @@ our $vm_option_properties = {
     ndp => {
         description => "Enable NDP (Neighbor Discovery Protocol).",
         type => 'boolean',
-        default => 0,
+        default => 1,
         optional => 1,
     },
     radv => {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH firewall 1/1] firewall: set default value of NDP to 1 for nodes and guests

[Thomas Lamprecht]

On Tue, 11 Nov 2025 11:25:46 +0100, Michael Köppl wrote:
> The default value of 0 is incorrect, as by default, NDP is enabled for
> both iptables and nftables. Change the default value to 1 to reflect
> that.
> 
> 

Applied, thanks!

But I reworded the commit message to avoid suggesting that the actual default
changed, but rather just the current default gets correctly documented, but
that there are no semantic changes.

[1/1] firewall: set default value of NDP to 1 for nodes and guests
      commit: 125ba064053d706bb50945c0291610173200f282


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel