From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0100C1FF15E for ; Mon, 10 Nov 2025 15:36:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1A3018EE8; Mon, 10 Nov 2025 15:37:03 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Mon, 10 Nov 2025 15:36:16 +0100 Message-ID: <20251110143627.365434-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251110143627.365434-1-d.kral@proxmox.com> References: <20251110143627.365434-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762785368095 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager 1/1] api: resources: fix uninitialized value in check_service_state X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" check_service_state(...) calls get_service_status(...), which assumes that a configured HA resource is already present in the manager status. If a HA resource is added to the configuration file and interacted with such that check_service_state(...) is called before the HA Manager loads the new HA resource in its state, then $service_status->{state} will be undefined. Signed-off-by: Daniel Kral --- src/PVE/API2/HA/Resources.pm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm index acdd4992..9d3460e5 100644 --- a/src/PVE/API2/HA/Resources.pm +++ b/src/PVE/API2/HA/Resources.pm @@ -38,7 +38,11 @@ sub check_service_state { my ($sid, $req_state) = @_; my $service_status = PVE::HA::Config::get_service_status($sid); - if ($service_status->{managed} && $service_status->{state} eq 'error') { + if ( + $service_status->{managed} + && $service_status->{state} + && $service_status->{state} eq 'error' + ) { # service in error state, must get disabled before new state request # can be executed return if defined($req_state) && $req_state eq 'disabled'; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel