[pve-devel] [PATCH yew-mobile-gui 0/3] update to edition 2024 and skip consent banner when openid authorization is present

[pve-devel] [PATCH yew-mobile-gui 0/3] update to edition 2024 and skip consent banner when openid authorization is present

[Shannon Sterz]

these patches update the rust edition of pve-yew-mobile-gui to 2024 and
also allow for skipping the consent banner in case an openid
authorization is present. this appraoch is analogous to the one used by
our javascript based front-ends.

Shannon Sterz (3):
  update rust edition to 2024
  dashboard panel: remove unnecessary binding modifiers
  page login: skip consent banner when openid authorization is present

 Cargo.toml                                    | 2 +-
 src/pages/page_login.rs                       | 5 ++++-
 src/pages/page_qemu_status/dashboard_panel.rs | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

--
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH yew-mobile-gui 1/3] update rust edition to 2024

[Shannon Sterz]

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 Cargo.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Cargo.toml b/Cargo.toml
index bb67718..7423384 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,7 +1,7 @@
 [package]
 name = "pve-yew-mobile-gui"
 version = "0.6.3"
-edition = "2021"
+edition = "2024"
 
 [dependencies]
 anyhow = "1.0"
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH yew-mobile-gui 2/3] dashboard panel: remove unnecessary binding modifiers

[Shannon Sterz]

this is now a compiler error in edition 2024 and ws unnecessary
anyway.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/pages/page_qemu_status/dashboard_panel.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pages/page_qemu_status/dashboard_panel.rs b/src/pages/page_qemu_status/dashboard_panel.rs
index 0a61d55..0250a58 100644
--- a/src/pages/page_qemu_status/dashboard_panel.rs
+++ b/src/pages/page_qemu_status/dashboard_panel.rs
@@ -335,7 +335,7 @@ impl Component for PveQemuDashboardPanel {
                         Ok(mut data) => {
                             // hack: The PVE api sometimes return Null for diskread/diskwrite
                             // so we simply remove Null values...
-                            if let Value::Object(ref mut map) = &mut data {
+                            if let Value::Object(map) = &mut data {
                                 map.retain(|_k, v| v != &Value::Null);
                             }
                             let data = serde_json::from_value::<QemuStatus>(data)
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH yew-mobile-gui 3/3] page login: skip consent banner when openid authorization is present

[Shannon Sterz]

improves ux so users don't have to agree to the consent banner twice.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
 src/pages/page_login.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/pages/page_login.rs b/src/pages/page_login.rs
index 7875af3..63fad30 100644
--- a/src/pages/page_login.rs
+++ b/src/pages/page_login.rs
@@ -10,6 +10,7 @@ use pwt::widget::{Button, Column, Row};
 use crate::widgets::TopNavBar;
 
 use proxmox_yew_comp::layout::card::standard_card;
+use proxmox_yew_comp::utils::openid_redirection_authorization;
 use proxmox_yew_comp::{LoginPanel, Markdown};
 
 use proxmox_login::Authentication;
@@ -68,7 +69,9 @@ impl Component for PvePageLogin {
             props.consent_text.as_ref().filter(|t| !t.is_empty())
         };
 
-        let content: Html = if let Some(consent_text) = consent_text {
+        let content: Html = if let Some(consent_text) = consent_text
+            && openid_redirection_authorization().is_none()
+        {
             let card = standard_card(tr!("Consent"), (), ())
                 .class("pwt-scheme-neutral")
                 .with_child(
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH yew-mobile-gui 0/3] update to edition 2024 and skip consent banner when openid authorization is present

[Dietmar Maurer]

applied,. thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel