From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 26FEF1FF187 for ; Mon, 3 Nov 2025 17:23:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10D9C22551; Mon, 3 Nov 2025 17:23:39 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 3 Nov 2025 17:23:11 +0100 Message-ID: <20251103162330.112603-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1762186997215 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES storage 0/4] lvm plugin: error handling and locking fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Patch 1/4 is improving an error message by including the previously captured error. Patch 2/4 fixes error handling in volume_snapshot_rollback(). Previously, allocation would be ignored when 'saferemove' was enabled on the storage. Patches 3/4 and 4/4 fix the locking for volume import and snapshot operations. Better viewed with "-w" or "-w --word-diff=color --word-diff-regex='\w+'". I noticed that the default timeout of 10 seconds for locking essentially means only having 10 tries to acquire the lock [0], which in a busy cluster might not be enough to get the lock with high confidence. This is not fully orthogonal to the series here, since we might want to either change that [0] or to use a higher timeout for (some of) the callers here. [0]: https://git.proxmox.com/?p=pve-cluster.git;a=blob;f=src/PVE/Cluster.pm;h=e829687a74224408106f74ee6873a44095f0ff4f;hb=HEAD#l601 pve-storage: Fiona Ebner (4): lvm plugin: snapshot delete: propagate previously captured error lvm plugin: fix error handling in volume_snapshot_rollback() lvm plugin: volume import: lock allocation and removal sections lvm plugin: snapshot-as-volume-chain: use locking for snapshot operations src/PVE/Storage/LVMPlugin.pm | 128 ++++++++++++++++++++++++++--------- 1 file changed, 96 insertions(+), 32 deletions(-) Summary over all repositories: 1 files changed, 96 insertions(+), 32 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel