From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 627971FF179 for ; Wed, 29 Oct 2025 14:12:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6373AA326; Wed, 29 Oct 2025 14:13:30 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 29 Oct 2025 14:12:40 +0100 Message-ID: <20251029131256.3124803-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2] ui: properly reset API 401 count X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" due to a timing race condition, it can happen that we try to increase the 401 count before resetting it (which happens after the first ticket api call). Since `undefined + ` === NaN, our later check for `> 5` never triggers and we don't show the login mask, but an empty window. To fix this, initialize the variable always with 0. Observed when restoring a session after a ticket expired while the browser was closed. Signed-off-by: Dominik Csapak --- changes from v1: * rebase on master www/manager6/Workspace.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js index a2574658..60c499cb 100644 --- a/www/manager6/Workspace.js +++ b/www/manager6/Workspace.js @@ -13,6 +13,8 @@ Ext.define('PVE.Workspace', { loginData: null, // Data from last login call + response401count: 0, + onLogin: function (loginData) { // override me }, -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel