From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5AA581FF179 for ; Wed, 29 Oct 2025 11:06:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08CC45479; Wed, 29 Oct 2025 11:07:24 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 29 Oct 2025 11:06:24 +0100 Message-ID: <20251029100646.27658-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251029100646.27658-1-f.ebner@proxmox.com> References: <20251029100646.27658-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761732396882 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common v4 1/2] systemd: add notify() helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Add a pure Perl reimplementation of systemd's sd_notify() mechanism as defined in systemd/sd-daemon.h based on the example implementations in 'man 3 sd_notify'. The initial user of this helper is intended to be the pve-dbus-vmstate service, so it can notify startup completion only once the dbus-vmstate QEMU object is ready to be used. EAGAIN is not checked for, because it does not occur for blocking Unix domain sockets, see 'man 2 send'. The socket is a datagram socket and a single datagram will be sent. If not all data can be written, error out like the example code in 'man 3 sd_notify'. Co-developed-by: Thomas Lamprecht Co-developed-by: Wolfgang Bumiller Signed-off-by: Fiona Ebner --- Changes in v4: * Also handle abstract socket path. * Only resend upon EINTR, otherwise the datagram should be sent in one go. * Drop unnecessary flush. * Drop $unset_environment argument. * Rename to just PVE::Systemd::notify() to make it clear that it's not the exact same as sd_notify(). * Use POD for documentation. * Return early if there is no socket path. * Die if there is no message. * Check that socket path starts with '/' or '@'. src/PVE/Systemd.pm | 49 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/src/PVE/Systemd.pm b/src/PVE/Systemd.pm index e6d6f88..8fc06a5 100644 --- a/src/PVE/Systemd.pm +++ b/src/PVE/Systemd.pm @@ -3,9 +3,12 @@ package PVE::Systemd; use strict; use warnings; +use IO::Socket::UNIX; use Net::DBus qw(dbus_uint32 dbus_uint64 dbus_boolean); use Net::DBus::Callback; use Net::DBus::Reactor; +use POSIX qw(EINTR); +use Socket qw(SOCK_DGRAM); use PVE::Tools qw(file_set_contents file_get_contents trim); @@ -282,4 +285,50 @@ sub write_ini { file_set_contents($filename, $content); } +=head3 notify() + +This is a pure Perl reimplementation of systemd's C mechanism as defined in +C, based on the example implementations in C. Does not return +a value, but dies upon error. + +=cut + +sub notify { + my ($message) = @_; + + # nothing to do if there is no socket + my $socket_path = $ENV{NOTIFY_SOCKET} or return; + + die "notify systemd invalid socket path '$socket_path'\n" if $socket_path !~ m|^[/@]|; + die "notify systemd called without a message\n" if !$message; + + # might be an abstract socket + $socket_path =~ s/^@/\0/; + + my $socket = IO::Socket::UNIX->new( + Type => SOCK_DGRAM(), + Peer => $socket_path, + ) or die "notify systemd: unable to connect to socket $socket_path - $IO::Socket::errstr\n"; + + # we won't be reading from the socket + $socket->shutdown(SHUT_RD); + + my $res; + while (1) { + $res = $socket->send($message); + if ($res) { + die "notify systemd: protocol error writing to socket '$socket_path'\n" + if $res < length($message); + last; + } else { + next if $! == EINTR; + die "notify systemd: sending to '$socket_path' failed - $!\n"; + } + } + + close($socket); + + return; +} + 1; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel