From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CB1C11FF179 for ; Wed, 29 Oct 2025 11:06:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2AB535485; Wed, 29 Oct 2025 11:06:54 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 29 Oct 2025 11:06:23 +0100 Message-ID: <20251029100646.27658-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1761732396819 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES common/qemu-server v4 0/2] migration: conntrack: fix race adding dbus-vmstate object to QEMU X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Changes in v4 (thanks to Wolfgang!): * Also handle abstract socket path. * Only resend upon EINTR, otherwise the datagram should be sent in one go. * Drop unnecessary flush. * Drop $unset_environment argument. * Rename to just PVE::Systemd::notify() to make it clear that it's not the exact same as sd_notify(). * Use POD for documentation. * Return early if there is no socket path. * Die if there is no message. * Check that socket path starts with '/' or '@'. Changes in v3 (thanks to Thomas!): * Expand commit message for sd_notify() helper. * Use $socket->{send,shutdown) methods. * Print $IO::Socket::errstr in case of error. * Unset NOTIFY_SOCKET environment variable only after sending the message. Changes in v2: * Dropped already applied patches. * Introduce sd_notify() helper. * Different approach, make the service type=notify instead of waiting in a sleep+check-loop until the object shows up via QMP 'qom-list'. As reported in the community forum [0], it might happen that the dbus-vmstate object is not added (quickly enough) to the target QEMU instance, before the migration state is loaded. This would result in a crash of the target instance. [0]: https://forum.proxmox.com/threads/172588/ Dependency bump qemu-server -> pve-common needed. pve-common: Fiona Ebner (1): systemd: add notify() helper src/PVE/Systemd.pm | 49 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) qemu-server: Fiona Ebner (1): migration: conntrack: avoid crash when dbus-vmstate object cannot be added (quickly enough) src/usr/dbus-vmstate | 3 +++ src/usr/pve-dbus-vmstate@.service | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) Summary over all repositories: 3 files changed, 53 insertions(+), 1 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel