From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 30DC51FF187 for ; Mon, 20 Oct 2025 18:46:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A229FDD4B; Mon, 20 Oct 2025 18:46:21 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Mon, 20 Oct 2025 18:45:31 +0200 Message-ID: <20251020164540.517231-6-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251020164540.517231-1-d.kral@proxmox.com> References: <20251020164540.517231-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1760978738557 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager v2 1/8] manager: remove redundant recompute_online_node_usage from next_state_recovery X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" recompute_online_node_usage(...) is currently only dependent on the configured CRS scheduler mode, the list of online nodes and the HA resource's state, current node and optional migration target. The proper recovery of HA resources was introduced in 9da84a0d ("fix 'change_service_location' misuse and recovery from fencing") as a private helper to recover fenced HA resources and the recompute_online_node_usage(...) was needed here. As the recovery of fenced HA resources is its own state for HA resources since c259b1a8 ("manager: make recovery actual state in FSM"), the change_service_state(...) to 'recovery' will already call recompute_online_node_usage(...) before, making this call redundant. Signed-off-by: Daniel Kral Reviewed-by: Fiona Ebner --- changes since v1: - added R-b src/PVE/HA/Manager.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index beaacf36..8a1e177d 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -1309,8 +1309,6 @@ sub next_state_recovery { my $fenced_node = $sd->{node}; # for logging purpose - $self->recompute_online_node_usage(); # we want the most current node state - my $recovery_node = select_service_node( $self->{rules}, $self->{online_node_usage}, -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel