From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6E05B1FF179 for ; Wed, 15 Oct 2025 10:03:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4FBBD14552; Wed, 15 Oct 2025 10:03:44 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Date: Wed, 15 Oct 2025 10:03:28 +0200 Message-ID: <20251015080330.45927-1-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH 0/2] improve error message when accessing a directory X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" I ran into this when I accidentally went to the path /pve-docs/api-viewer instead of /pve-docs/api-viewer/index.html, where I got this error: `unable to detect content type at /usr/share/perl5/PVE/APIServer/AnyEvent.pm line 499.` Which IMO was not very telling of the underlying mistake I had made. This patch aims to improve this error message by checking if the queried file is a directory and returning a more descriptive message to the user. I'm not sure (since I'm not too familiar with this codebase) if this breaks any existing functionality I may have missed or was intended behaviour, though I didn't find anything that would suggest this. See also: https://perldoc.perl.org/IO::File#NOTE Nicolas Frey (2): apiserver: fix typo apiserver: check if file is directory before opening src/PVE/APIServer/AnyEvent.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel