From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4B5761FF15C for ; Fri, 3 Oct 2025 17:00:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6AE87155; Fri, 3 Oct 2025 17:00:49 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 3 Oct 2025 17:00:41 +0200 Message-ID: <20251003150045.3359961-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759503621237 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server, manager v8 0/4] fix #1926 autodetect xtermjs or novnc for VM console X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Here is a new verson for this fix. Nothing changed since v7 expect rebasing. Quite a bit happened since then, but the rebase should be fine by now. I gave it a quick test on my workstation and things seem to work as expected. A quick test by someone else might be warranted though, just to be safe. I added all the R-b and T-b tags that were added on v7 direclty into each patch. Hopefully as they should be (chronological). The old cover letter that explains what is happening below: After the feedback from Fiona on v6 and some off-list discussion, we decided to improve the backend part by moving the "default" logic out of `get_vga_properties` and move it into a separate public `get_default_vga_type` function. This way we can leave all the other functions private to the QemuServer.pm module. We add a new property in the VM status/current API result that includes the display configurtion of the VM. This way we can check in the frontend what to do with it. I chose a nested return value, as that makes it easier to add/move additional display properties into it. Patch 1/4 moves the default display logic into its own public function Patch 2/4 adds the new display property. If not explicitly set in the VM config, it will return the default value. Patch 3/4 implements the changes in the UI. The final result isn't really a lot simpler on the UI side than in V4 where we had the extra API call to the VM's config directly. Because we still need to wait for the API call to finish when initially navigating to the VM. But we have one fewer call. Patch 4/4 then introduces some changes to make loading of the console faster if we just navigate in the submenu of a VM itself where we already have the current status of a VM already cached. Changes from v7: rebased v6: backend only: create new `get_default_vga_type` function. v5: implement suggestions: * use get_vga_properties for default VGA * UI: use helper to determine if serial display Aaron Lauterer (2): add new public get_default_vga_type function api: status/current: add display property src/PVE/API2/Qemu.pm | 13 +++++++++++++ src/PVE/QemuServer.pm | 29 ++++++++++++++++++++++------- 2 files changed, 35 insertions(+), 7 deletions(-) -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel