From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CB6DC1FF17E for ; Thu, 2 Oct 2025 14:48:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2C29F1A4; Thu, 2 Oct 2025 14:48:04 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Date: Thu, 2 Oct 2025 14:47:27 +0200 Message-ID: <20251002124728.103425-2-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251002124728.103425-1-n.frey@proxmox.com> References: <20251002124728.103425-1-n.frey@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.170 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v3 1/2] api: add APT versions return schema X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The Arch property now includes all officially supported debian Architectures [0]. These could be extended to include unofficial ones as well, though I don't see a reason to currently do this. The CurrentState property now includes all variants according to the documentation of package AptPkg::Cache. Also implemented suggestion to clone $apt_package_return_props instead of modifying, which could've potentially resulted in unwanted behaviour. [0] https://wiki.debian.org/SupportedArchitectures Signed-off-by: Nicolas Frey --- PVE/API2/APT.pm | 114 +++++++++++++++++++++++++++++------------------- 1 file changed, 68 insertions(+), 46 deletions(-) diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm index 0d07cf38..fdc9f622 100644 --- a/PVE/API2/APT.pm +++ b/PVE/API2/APT.pm @@ -200,6 +200,52 @@ my $update_pve_pkgstatus = sub { return $pkglist; }; +my $apt_package_return_props = { + Arch => { + type => 'string', + description => 'Package Architecture.', + enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x)], + }, + Description => { + type => 'string', + description => 'Package description.', + }, + NotifyStatus => { + type => 'string', + description => 'Version for which PVE has already sent an update notification for.', + optional => 1, + }, + OldVersion => { + type => 'string', + description => 'Old version currently installed.', + optional => 1, + }, + Origin => { + type => 'string', + description => "Package origin, e.g., 'Proxmox' or 'Debian'.", + }, + Package => { + type => 'string', + description => 'Package name.', + }, + Priority => { + type => 'string', + description => 'Package priority.', + }, + Section => { + type => 'string', + description => 'Package section.', + }, + Title => { + type => 'string', + description => 'Package title.', + }, + Version => { + type => 'string', + description => 'New version to be updated to.', + }, +}; + __PACKAGE__->register_method({ name => 'list_updates', path => 'update', @@ -220,51 +266,7 @@ __PACKAGE__->register_method({ type => "array", items => { type => "object", - properties => { - 'Arch' => { - type => 'string', - description => 'Package Architecture.', - }, - 'Description' => { - type => 'string', - description => 'Human-readable package description.', - }, - 'NotifyStatus' => { - type => 'string', - description => - 'Version for which PVE has already sent an update notification for.', - optional => 1, - }, - 'OldVersion' => { - type => 'string', - description => 'Old version currently installed.', - optional => 1, - }, - 'Origin' => { - type => 'string', - description => 'Package origin.', - }, - 'Package' => { - type => 'string', - description => 'Package name.', - }, - 'Priority' => { - type => 'string', - description => 'Package priority in human-readable form.', - }, - 'Section' => { - type => 'string', - description => 'Package section.', - }, - 'Title' => { - type => 'string', - description => 'Package title.', - }, - 'Version' => { - type => 'string', - description => 'New version to be updated to.', - }, - }, + properties => $apt_package_return_props, }, }, code => sub { @@ -788,7 +790,27 @@ __PACKAGE__->register_method({ type => "array", items => { type => "object", - properties => {}, + properties => { + $apt_package_return_props->%*, + CurrentState => { + type => 'string', + description => 'Current state of the package installed on the system.', + # Possible CurrentState variants according to AptPkg::Cache + enum => [ + qw(Installed NotInstalled UnPacked HalfConfigured HalfInstalled ConfigFiles) + ], + }, + RunningKernel => { + type => 'string', + description => "Kernel release, only for package 'proxmox-ve'.", + optional => 1, + }, + ManagerVersion => { + type => 'string', + description => "Version of the currently running pve-manager API server.", + optional => 1, + }, + } }, }, code => sub { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel