From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B50571FF17E for ; Thu, 2 Oct 2025 13:25:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 52A3ED8EC; Thu, 2 Oct 2025 13:26:03 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 2 Oct 2025 13:17:25 +0200 Message-ID: <20251002112528.3128880-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit] window: acme account: hide e-mail field if it does not exist X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" it seems that currently, the account information returned by letsencrypt does not include the contact anymore, so there is no 'contact' field in the 'account' property. To not trip up the ui, only optionally read that out, and hide the field completely if it does not exist. Signed-off-by: Dominik Csapak --- I looked in the backend, we save the 'account' object verbatim from the api response, and the RFC [0] says it should have a contact field, but it's not there in my tests with the staging + normal api, so not sure if this is the right fix. 0: https://www.rfc-editor.org/rfc/rfc8555#section-9.7.1 src/window/ACMEAccount.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/window/ACMEAccount.js b/src/window/ACMEAccount.js index 095e674..939ddf2 100644 --- a/src/window/ACMEAccount.js +++ b/src/window/ACMEAccount.js @@ -191,10 +191,11 @@ Ext.define('Proxmox.window.ACMEAccountView', { me.load({ success: function (response) { var data = response.result.data; - data.email = data.account.contact[0]; + data.email = data.account.contact?.[0]; data.createdAt = data.account.createdAt; data.status = data.account.status; me.setValues(data); + me.down('field[name=email]').setHidden(!data.email); }, }); }, -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel