From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F37C61FF179 for ; Wed, 1 Oct 2025 12:48:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 196941D530; Wed, 1 Oct 2025 12:48:07 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Wed, 1 Oct 2025 12:47:10 +0200 Message-ID: <20251001104729.70314-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251001104729.70314-1-f.ebner@proxmox.com> References: <20251001104729.70314-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759315631273 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qmpclient.pm, proxmox.com] Subject: [pve-devel] [PATCH qemu-server 1/4] qmp client: encode JSON as UTF-8 to fix PBS backup when password contains multi-byte UTF-8 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As reported in the community forum, PBS backup of VMs would not work when the password contained a multi-byte UTF-8 character [0]. The reason is that when writing a string in Perl's internal representation with character values >= 128 to the QMP socket, QEMU seems to have a bug where it reads too few characters (one less for each char value >= 128). In such a case, the QMP client will just time out, as the command is never completely read on the QEMU side. Stuffing with additional characters would actually lead to QEMU reading enough characters and executing the command, but Perl's internal representation should not be submitted to QMP in the first place. Encode the JSON properly as UTF-8 to avoid the issue. In particular, this makes backing up a VM to PBS possible when the PBS password contains multi-byte UTF-8 characters. This also fixes future similar issues, for example when a QMP command is passed a filesystem path with multi-byte UTF-8 characters. [0]: https://forum.proxmox.com/threads/172871/post-804921 Signed-off-by: Fiona Ebner --- Unfortunately, doing the same for QGA is not yet enough to fix issue #6609. src/PVE/QMPClient.pm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/PVE/QMPClient.pm b/src/PVE/QMPClient.pm index 7b19be9d..46d8b299 100644 --- a/src/PVE/QMPClient.pm +++ b/src/PVE/QMPClient.pm @@ -291,12 +291,14 @@ my $check_queue = sub { . "\n"; } else { - - $qmpcmd = to_json({ - execute => $cmd->{execute}, - arguments => $cmd->{arguments}, - id => $cmd->{id}, - }); + $qmpcmd = to_json( + { + execute => $cmd->{execute}, + arguments => $cmd->{arguments}, + id => $cmd->{id}, + }, + { utf8 => 1 }, + ); } if ($fd >= 0) { -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel