From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 97F581FF179 for ; Wed, 1 Oct 2025 12:47:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 40C3B1D1CC; Wed, 1 Oct 2025 12:47:37 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Wed, 1 Oct 2025 12:47:09 +0200 Message-ID: <20251001104729.70314-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759315631257 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pbsclient.pm, pbsplugin.pm, qmpclient.pm, qemuserver.pm] Subject: [pve-devel] [PATCH-SERIES qemu-server/storage/common 0/4] fix UTF-8 handling for PBS_PASSWORD X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The PBS password is saved as UTF-8 and decoded to Perl's internal string representation upon reading from the password file. When the password contains multi-byte UTF-8 characters, backing up a diskless VM would fail with: > Error: error building client for repository XXX - > PBS_PASSWORD contains bad characters The same error would occur for uploading the log file after backup, as well as extracting the configuration file from backup. Restoring would fail with: > restore failed: invalid utf-8 sequence of 1 bytes from index 0 Fix these issues by properly encoding the value for the PBS_PASSWORD environment variable value again as UTF-8. For PMG, using passwords that would be auto-encoded by Perl as either ASCII or UTF-8 already worked, but other encodings would not, for example ISO-8859 would result in: > proxmox-backup-client failed: Error: error building client for > repository latin@pbs@10.10.100.180:8007:bigone - PBS_PASSWORD > contains bad characters (500) Follow pve-storage commit 5245e04 ("fix #5181: pbs: store and read passwords as unicode") and align the behavior of the storage plugin and pbs client module. qemu-server: Fiona Ebner (2): qmp client: encode JSON as UTF-8 to fix PBS backup when password contains multi-byte UTF-8 pbs: properly encode PBS password as UTF-8 when setting the environment variable src/PVE/QMPClient.pm | 14 ++++++++------ src/PVE/QemuServer.pm | 4 ++++ src/PVE/VZDump/QemuServer.pm | 4 ++++ 3 files changed, 16 insertions(+), 6 deletions(-) storage: Fiona Ebner (1): pbs plugin: raw client command: properly encode PBS password as UTF-8 when setting the environment variable src/PVE/Storage/PBSPlugin.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) common: Fiona Ebner (1): pbs client: allow using password that would be auto-encoded as neither ASCII nor UTF-8 src/PVE/PBSClient.pm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) Summary over all repositories: 5 files changed, 32 insertions(+), 11 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel