From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5F0461FF16F for ; Tue, 30 Sep 2025 16:21:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C0FE9A20; Tue, 30 Sep 2025 16:20:58 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Tue, 30 Sep 2025 16:19:13 +0200 Message-ID: <20250930142021.366529-7-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250930142021.366529-1-d.kral@proxmox.com> References: <20250930142021.366529-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759242004054 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager 3/9] manager: remove redundant add_service_usage_to_node from next_state_recovery X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Since 5c2eef4b ("account service to source and target during move") a moving HA resource's load is accounted for on the source and target nodes. A HA resource is in the 'recovery' state after a successfully fenced node and its primary goal becomes to find a recovery node. As soon as a recovery node is found, the HA resource is moved there. As the previous node was fenced, there is only load on the recovery node. The add_service_usage_to_node(...) is redundant at this point as the subsequent call to change_service_state(...) to either the 'started' or 'request_stop' state will call recompute_online_node_usage(...) and make the changes to $online_node_usage be discarded immediately. Signed-off-by: Daniel Kral --- src/PVE/HA/Manager.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index f69a7fe9..6afc9250 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -1321,8 +1321,6 @@ sub next_state_recovery { $fence_recovery_cleanup->($self, $sid, $fenced_node); $haenv->steal_service($sid, $sd->{node}, $recovery_node); - $self->{online_node_usage}->add_service_usage_to_node($recovery_node, $sid, $recovery_node); - $self->{online_node_usage}->add_service_node($sid, $recovery_node); # NOTE: $sd *is normally read-only*, fencing is the exception $cd->{node} = $sd->{node} = $recovery_node; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel