From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CE9DE1FF15E for ; Mon, 29 Sep 2025 16:35:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF2CF15C00; Mon, 29 Sep 2025 16:35:56 +0200 (CEST) From: Nicolas Frey To: pve-devel@lists.proxmox.com Date: Mon, 29 Sep 2025 16:35:52 +0200 Message-ID: <20250929143552.191504-1-n.frey@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.162 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager] fix #6379: apply vzdump.conf compress default to GUI. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Ensure the GUI uses the default 'compress' value in /etc/vzdump.conf for manual backups and Backup Jobs, matching vzdump CLI behavior. Backup Jobs continue to use the cluster-wide default of 'zstd'. When a single node is selected, the job now uses that node's default 'compress' value from /etc/vzdump.conf. Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6379 Signed-off-by: Nicolas Frey --- www/manager6/dc/Backup.js | 21 +++++++++++++++++++++ www/manager6/window/Backup.js | 3 +++ 2 files changed, 24 insertions(+) diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js index 956a7cdf..7cca08ca 100644 --- a/www/manager6/dc/Backup.js +++ b/www/manager6/dc/Backup.js @@ -76,6 +76,27 @@ Ext.define('PVE.dc.BackupEdit', { if (mode === 'pool') { me.selectPoolMembers(); } + + let compressionSelector = me.lookup('compressionSelector'); + if (value !== undefined && value !== '' && value !== null) { + Proxmox.Utils.API2Request({ + url: `/nodes/${value}/vzdump/defaults`, + method: 'GET', + success: function (response, _) { + const data = response.result.data; + + if (data.compress !== undefined) { + compressionSelector.setValue(data.compress); + } + }, + failure: function (response, _) { + Ext.Msg.alert(gettext('Error'), response.htmlStatus); + }, + }); + } else { + // default value for cluster-wide backup + compressionSelector.setValue('zstd'); + } }, storageChange: function (f, v) { diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 65ec9659..cf6d4e4c 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -193,6 +193,9 @@ Ext.define('PVE.window.Backup', { PVE.Utils.unEscapeNotesTemplate(data['notes-template']), ); } + if (!initialDefaults && data.compress !== undefined) { + compressionSelector.setValue(data.compress); + } initialDefaults = true; -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel