From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 515091FF165 for ; Thu, 25 Sep 2025 18:12:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E999A25D28; Thu, 25 Sep 2025 18:12:54 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 25 Sep 2025 18:12:46 +0200 Message-ID: <20250925161250.436548-3-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250925161250.436548-1-s.hanreich@proxmox.com> References: <20250925161250.436548-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.182 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH proxmox-firewall 2/3] firewall: set auto-merge flag for ipsets X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" ipsets that contained overlapping ip ranges caused the firewall to generate a ruleset rejected by nftables, because nftables interval sets do not support overlapping ranges by default. By explicitly enabling the auto-merge flag we prevent the firewall from failing due to overlapping elements in ipsets. nftables sets then automatically merge elements that are overlapping / adjacent. This issue was reported in the forum [1]. [1] https://forum.proxmox.com/threads/proxmox-firewall-nftables-troubleshooting.164560/#post-760973 Signed-off-by: Stefan Hanreich --- proxmox-firewall/src/object.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/proxmox-firewall/src/object.rs b/proxmox-firewall/src/object.rs index 5c18708..5dde7c2 100644 --- a/proxmox-firewall/src/object.rs +++ b/proxmox-firewall/src/object.rs @@ -124,8 +124,9 @@ impl ToNftObjects for Ipset { SetName::ipset_name(family, self.name(), env.vmid, false), ); - let set_config = - SetConfig::new(set_name.clone(), vec![element_type]).with_flag(SetFlag::Interval); + let set_config = SetConfig::new(set_name.clone(), vec![element_type]) + .with_flag(SetFlag::Interval) + .with_auto_merge(true); let nomatch_name = SetName::new( env.table.clone(), @@ -133,7 +134,8 @@ impl ToNftObjects for Ipset { ); let nomatch_config = SetConfig::new(nomatch_name.clone(), vec![element_type]) - .with_flag(SetFlag::Interval); + .with_flag(SetFlag::Interval) + .with_auto_merge(true); commands.append(&mut vec![ Add::set(set_config), -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel