From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7C92C1FF187 for ; Mon, 22 Sep 2025 11:46:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D2E7A16AF3; Mon, 22 Sep 2025 11:46:40 +0200 (CEST) Date: Mon, 22 Sep 2025 11:45:58 +0200 From: Stoiko Ivanov To: Fiona Ebner Message-ID: <20250922114558.0247bac4@rosa.proxmox.com> In-Reply-To: <20250918135215.95188-2-f.ebner@proxmox.com> References: <20250918135215.95188-1-f.ebner@proxmox.com> <20250918135215.95188-2-f.ebner@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758534386060 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH common 1/4] pty: introduce read_line() function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" tested this patch with the patches for PMG from: https://lore.proxmox.com/pmg-devel/20250918142052.131956-1-f.ebner@proxmox.com/T/#t worked for me when creating an acme account with custom ACME provider, and when joining a cluster. Consider this: Reviewed-by: Stoiko Ivanov Tested-by: Stoiko Ivanov On Thu, 18 Sep 2025 15:50:53 +0200 Fiona Ebner wrote: > From: Stefan Hrdlicka > > Originally-by: Stefan Hrdlicka > [FE: avoid changes to read_password() > rename from read_input() to read_line() > avoid undef warning if there is no input by avoiding chomp then > print prompt even if not reading from interactive for better log] > Signed-off-by: Fiona Ebner > --- > src/PVE/PTY.pm | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/src/PVE/PTY.pm b/src/PVE/PTY.pm > index 5d7d697..1db4863 100644 > --- a/src/PVE/PTY.pm > +++ b/src/PVE/PTY.pm > @@ -163,6 +163,23 @@ sub tcsetsize($$$) { > or die "failed to set window size: $!\n"; > } > > +sub read_line($;$$) { > + my ($query, $infd, $outfd) = @_; > + > + $infd //= \*STDIN; > + $outfd //= \*STDOUT; > + > + my $msg = -t $infd ? $query : "$query\n"; > + print $outfd $msg; > + > + my $input = ''; > + local $/ = "\n"; > + $input = <$infd>; > + chomp $input if $input; > + > + return $input; > +} > + > sub read_password($;$$) { > my ($query, $infd, $outfd) = @_; > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel