From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 37EA81FF17E for ; Thu, 18 Sep 2025 15:52:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AD582D70; Thu, 18 Sep 2025 15:52:22 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 18 Sep 2025 15:50:53 +0200 Message-ID: <20250918135215.95188-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250918135215.95188-1-f.ebner@proxmox.com> References: <20250918135215.95188-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758203529608 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH common 1/4] pty: introduce read_line() function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" From: Stefan Hrdlicka Originally-by: Stefan Hrdlicka [FE: avoid changes to read_password() rename from read_input() to read_line() avoid undef warning if there is no input by avoiding chomp then print prompt even if not reading from interactive for better log] Signed-off-by: Fiona Ebner --- src/PVE/PTY.pm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/PVE/PTY.pm b/src/PVE/PTY.pm index 5d7d697..1db4863 100644 --- a/src/PVE/PTY.pm +++ b/src/PVE/PTY.pm @@ -163,6 +163,23 @@ sub tcsetsize($$$) { or die "failed to set window size: $!\n"; } +sub read_line($;$$) { + my ($query, $infd, $outfd) = @_; + + $infd //= \*STDIN; + $outfd //= \*STDOUT; + + my $msg = -t $infd ? $query : "$query\n"; + print $outfd $msg; + + my $input = ''; + local $/ = "\n"; + $input = <$infd>; + chomp $input if $input; + + return $input; +} + sub read_password($;$$) { my ($query, $infd, $outfd) = @_; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel