From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 4791E1FF16F for ; Tue, 16 Sep 2025 14:35:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7678C13B38; Tue, 16 Sep 2025 14:35:46 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Tue, 16 Sep 2025 14:32:48 +0200 Message-ID: <20250916123257.107491-4-f.schauer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20250916123257.107491-1-f.schauer@proxmox.com> References: <20250916123257.107491-1-f.schauer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758026105804 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH storage v8 3/9] plugin: allow volume import of iso, snippets, vztmpl and import X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Extend volume import functionality to support 'iso', 'snippets', 'vztmpl', and 'import' types, in addition to the existing support for 'images' and 'rootdir'. This is a prerequisite for the ability to move ISOs, snippets and container templates between nodes. Existing behavior for importing VM disks and container volumes remains unchanged. Signed-off-by: Filip Schauer --- src/PVE/Storage/Plugin.pm | 89 ++++++++++++++++++++++++--------------- 1 file changed, 56 insertions(+), 33 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index 2291d72..ecf68c8 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -2039,7 +2039,7 @@ sub volume_export { if ($format eq 'raw+size') { die $err_msg if $with_snapshots || $file_format eq 'subvol'; write_common_header($fh, $size); - if ($file_format eq 'raw') { + if ($file_format =~ /^(raw|ova|ovf)$/) { run_command( ['dd', "if=$file", "bs=4k", "status=progress"], output => '>&' . fileno($fh), @@ -2085,14 +2085,14 @@ sub volume_export { sub volume_export_formats { my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_; if ($scfg->{path} && !defined($snapshot) && !defined($base_snapshot)) { - my $format = ($class->parse_volname($volname))[6]; + my ($vtype, $format) = ($class->parse_volname($volname))[0, 6]; if ($with_snapshots) { return ($format . '+size') if ($format eq 'qcow2' || $format eq 'vmdk'); return (); } return ('tar+size') if $format eq 'subvol'; - return ('raw+size'); + return ('raw+size') if $vtype =~ /^(iso|snippets|vztmpl|import)$/; } return (); } @@ -2126,14 +2126,20 @@ sub volume_import { # XXX: Should we bother with conversion routines at this level? This won't # happen without manual CLI usage, so for now we just error out... - die "cannot import format $format into a file of format $file_format\n" - if $data_format ne $file_format && !($data_format eq 'tar' && $file_format eq 'subvol'); + if ( + ($vtype eq 'images' || $vtype eq 'rootdir') + && $data_format ne $file_format + && !($data_format eq 'tar' && $file_format eq 'subvol') + ) { + die "cannot import format $format into a file of format $file_format\n"; + } # Check for an existing file first since interrupting alloc_image doesn't # free it. my ($file) = $class->path($scfg, $volname, $storeid); if (-e $file) { - die "file '$file' already exists\n" if !$allow_rename; + die "file '$file' already exists\n" + if !$allow_rename || ($vtype ne 'images' && $vtype ne 'rootdir'); warn "file '$file' already exists - importing with a different name\n"; $name = undef; } @@ -2141,33 +2147,49 @@ sub volume_import { my ($size) = read_common_header($fh); $size = PVE::Storage::Common::align_size_up($size, 1024) / 1024; - eval { - my $allocname = $class->alloc_image($storeid, $scfg, $vmid, $file_format, $name, $size); - my $oldname = $volname; - $volname = $allocname; - if (defined($name) && $allocname ne $oldname) { - die "internal error: unexpected allocated name: '$allocname' != '$oldname'\n"; + if ($vtype eq 'images' || $vtype eq 'rootdir') { + eval { + my $allocname = + $class->alloc_image($storeid, $scfg, $vmid, $file_format, $name, $size); + my $oldname = $volname; + $volname = $allocname; + if (defined($name) && $allocname ne $oldname) { + die "internal error: unexpected allocated name: '$allocname' != '$oldname'\n"; + } + my ($file) = $class->path($scfg, $volname, $storeid) + or die "internal error: failed to get path to newly allocated volume $volname\n"; + if ($data_format eq 'raw' || $data_format eq 'qcow2' || $data_format eq 'vmdk') { + run_command( + ['dd', "of=$file", 'conv=sparse', 'bs=64k'], + input => '<&' . fileno($fh), + ); + } elsif ($data_format eq 'tar') { + run_command( + ['tar', @COMMON_TAR_FLAGS, '-C', $file, '-xf', '-'], + input => '<&' . fileno($fh), + ); + } else { + die "volume import format '$format' not available for $class"; + } + }; + if (my $err = $@) { + eval { $class->free_image($storeid, $scfg, $volname, 0, $file_format) }; + warn $@ if $@; + die $err; } - my ($file) = $class->path($scfg, $volname, $storeid) - or die "internal error: failed to get path to newly allocated volume $volname\n"; - if ($data_format eq 'raw' || $data_format eq 'qcow2' || $data_format eq 'vmdk') { - run_command( - ['dd', "of=$file", 'conv=sparse', 'bs=64k'], - input => '<&' . fileno($fh), - ); - } elsif ($data_format eq 'tar') { - run_command( - ['tar', @COMMON_TAR_FLAGS, '-C', $file, '-xf', '-'], - input => '<&' . fileno($fh), - ); - } else { - die "volume import format '$format' not available for $class"; + } elsif (grep { $vtype eq $_ } qw(import iso snippets vztmpl)) { + eval { + run_command(['dd', "of=$file", 'conv=excl', 'bs=64k'], input => '<&' . fileno($fh)); + }; + if (my $err = $@) { + if (-e $file) { + eval { unlink($file) }; + warn $@ if $@; + } + die $err; } - }; - if (my $err = $@) { - eval { $class->free_image($storeid, $scfg, $volname, 0, $file_format) }; - warn $@ if $@; - die $err; + } else { + die "importing volume of type '$vtype' not implemented\n"; } return "$storeid:$volname"; @@ -2176,13 +2198,14 @@ sub volume_import { sub volume_import_formats { my ($class, $scfg, $storeid, $volname, $snapshot, $base_snapshot, $with_snapshots) = @_; if ($scfg->{path} && !defined($base_snapshot)) { - my $format = ($class->parse_volname($volname))[6]; + my ($vtype, $format) = ($class->parse_volname($volname))[0, 6]; + if ($with_snapshots) { return ($format . '+size') if ($format eq 'qcow2' || $format eq 'vmdk'); return (); } return ('tar+size') if $format eq 'subvol'; - return ('raw+size'); + return ('raw+size') if $vtype =~ /^(iso|snippets|vztmpl|import)$/; } return (); } -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel