From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 7C8B31FF15E for ; Mon, 15 Sep 2025 10:48:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E6C01E7FD; Mon, 15 Sep 2025 10:48:09 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Date: Mon, 15 Sep 2025 10:47:59 +0200 Message-ID: <20250915084801.48170-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1757926079310 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH network] fix #6806: sdn: allow nic* and if* interfaces as bridge ports X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When creating a vlan zone and vnet, we get all the bridge interfaces (slaves) and add them to the new vlan bridge. We get all the bridge interfaces using `/sys/class/net` and then filter them using a regex. This regex was missing the new `if` and `nic` prefixes which were introduced with the pve-network-interface-pinning tool. This is more of a stop-gap, we can probably remove the regex completely as I don't see any reason to filter by "physical" interfaces here. If there is a need, we can still run `ip link` and check the attributes with `PVE::Network::ip_link_is_physical`. Fixes: #6806 Signed-off-by: Gabriel Goller --- src/PVE/Network/SDN/Zones/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm index 83372e703cf5..0a977fd35a13 100644 --- a/src/PVE/Network/SDN/Zones/Plugin.pm +++ b/src/PVE/Network/SDN/Zones/Plugin.pm @@ -371,7 +371,7 @@ sub get_bridge_ifaces { my $dir = "/sys/class/net/$bridge/brif"; PVE::Tools::dir_glob_foreach( $dir, - '(((eth|bond)\d+|en[^.]+)(\.\d+)?)', + '(((eth|bond|nic|if)\d+|en[^.]+)(\.\d+)?)', sub { push @bridge_ifaces, $_[0]; }, -- 2.47.3 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel