From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 15AED1FF191 for ; Tue, 9 Sep 2025 15:26:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 09ED1AB0F; Tue, 9 Sep 2025 15:26:24 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 9 Sep 2025 15:25:57 +0200 Message-ID: <20250909132613.96402-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1757424356053 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES qemu-server v2 0/5] guest agent: better handle lost freeze command X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Changes in v2: * Rebase on current master. * Drop already applied patches. * Slightly improve log messages. * Slightly improve commit messages. The main bit of the series is patch "agent: implement fsfreeze helper to better handle lost commands". As reported in the enterprise support, it can happen that a guest agent command is read, but then the guest agent never sends an answer, because the service in the guest is stopped/killed. For example, if a guest reboot happens before the command can be successfully executed. This is usually not problematic, but the fsfreeze-freeze command has a timeout of 1 hour, so the guest agent socket would be blocked for that amount of time, waiting on a command that is not being executed anymore. Use a lower timeout for the fsfreeze-freeze command, and issue an fsfreeze-status command afterwards, which will return immediately if the fsfreeze-freeze command already finished, and which will be queued if not. This is used as a proxy to determine whether the fsfreeze-freeze command is still running and to check whether it was successful. Like this, the time the socket is blocked after a "lost command" is at most 10 minutes. The rest of the series is preparation and cleanups. Fiona Ebner (5): api: agent: improve module imports qmp client: remove erroneous comment agent: implement fsfreeze helper to better handle lost commands agent: prefer usage of get_qga_key() helper agent: move guest agent format and parsing to agent module src/PVE/API2/Qemu.pm | 4 +- src/PVE/API2/Qemu/Agent.pm | 9 ++- src/PVE/QMPClient.pm | 5 +- src/PVE/QemuConfig.pm | 6 +- src/PVE/QemuMigrate.pm | 3 +- src/PVE/QemuServer.pm | 54 +-------------- src/PVE/QemuServer/Agent.pm | 122 +++++++++++++++++++++++++++++++++ src/PVE/QemuServer/BlockJob.pm | 2 +- src/PVE/VZDump/QemuServer.pm | 7 +- 9 files changed, 146 insertions(+), 66 deletions(-) -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel