From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A209E1FF187 for ; Mon, 8 Sep 2025 20:01:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 65358188F3; Mon, 8 Sep 2025 20:01:17 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Date: Mon, 8 Sep 2025 20:00:52 +0200 Message-ID: <20250908180058.530119-9-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250908180058.530119-1-m.carrara@proxmox.com> References: <20250908180058.530119-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1757354452481 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC pve-storage master v1 08/12] plugin: zfspool: add 'short-name' and form view for ZFS pool plugin X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This commit demonstrates how the 'short-name' key and the `get_form_view()` method can be added to a plugin. Signed-off-by: Max R. Carrara --- src/PVE/Storage/ZFSPoolPlugin.pm | 67 ++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/src/PVE/Storage/ZFSPoolPlugin.pm b/src/PVE/Storage/ZFSPoolPlugin.pm index d8d8d0f..6de5ee1 100644 --- a/src/PVE/Storage/ZFSPoolPlugin.pm +++ b/src/PVE/Storage/ZFSPoolPlugin.pm @@ -20,9 +20,13 @@ sub type { sub plugindata { return { + 'short-name' => 'ZFS', content => [{ images => 1, rootdir => 1 }, { images => 1, rootdir => 1 }], format => [{ raw => 1, subvol => 1 }, 'raw'], 'sensitive-properties' => {}, + views => { + form => 1, + }, }; } @@ -140,6 +144,69 @@ sub on_add_hook { return; } +sub get_form_view { + my ($class, $context) = @_; + + my $pool_selection_values = []; + + my $cmd = ['zfs', 'list', '-t', 'filesystem', '-Hp', '-o', 'name']; + run_command( + $cmd, + outfunc => sub { + my ($line) = @_; + + if ($line =~ m/ ^ (?\S+) \s* $/xn) { + my $pool = $+{pool}; + push($pool_selection_values->@*, [$pool, $pool]); + } + }, + ); + + $pool_selection_values = [ sort { $a->[0] cmp $b->[0] } $pool_selection_values->@* ]; + + my $view = { + version => 1, + definition => { + general => { + columns => [ + { + fields => [ + { + property => 'pool', + label => "Pool", + 'field-type' => 'selection', + attributes => { + 'selection-values' => $pool_selection_values, + required => 1, + readonly => $context->{mode} eq 'update', + }, + }, + ], + }, + { + fields => [ + { + property => 'sparse', + label => "Thin provision", + 'field-type' => 'boolean', + attributes => {}, + }, + { + property => 'blocksize', + label => "Block Size", + 'field-type' => 'string', + attributes => {}, + }, + ], + }, + ], + }, + }, + }; + + return $view; +} + sub path { my ($class, $scfg, $volname, $storeid, $snapname) = @_; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel