From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2D8FF1FF15C for ; Fri, 5 Sep 2025 14:06:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9997A13B6C; Fri, 5 Sep 2025 14:06:32 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 5 Sep 2025 13:51:59 +0200 Message-ID: <20250905120627.2585826-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250905120627.2585826-1-d.csapak@proxmox.com> References: <20250905120627.2585826-1-d.csapak@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.128 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/4] API2Tools: rrd: remove O(n^2) lookup for keys X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" the idea was that we get any of the 'new' versions on lookup, but that lead to iterating through possibly all keys. Since that was called for each resource in e.g. /cluster/resources api call, the runtime was O(n^2) for the number of resources. To avoid that, simply look up the currently only valid key here which makes this lookup much cheaper. In my test setup with ~10000 guests, it reduces the time for a call to /cluster/resources from ~22s to ~400ms Signed-off-by: Dominik Csapak --- NOTE: this is only a workaround and Aaron is working to making this whole part unnecessary, but for now i think this is a good stop-gap PVE/API2Tools.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/PVE/API2Tools.pm b/PVE/API2Tools.pm index abe73fa2..863f5f55 100644 --- a/PVE/API2Tools.pm +++ b/PVE/API2Tools.pm @@ -52,10 +52,9 @@ sub get_rrd_key { return "pve2.3-${type}/${id}"; } - # if no old key has been found, we expect on in the newer format: pve-{type}-{version}/{id} - # We accept all new versions, as the expectation is that they are only allowed to add new colums as non-breaking change - for my $k (keys %$rrd) { - return $k if $k =~ m/^pve-\Q${type}\E-\d\d?.\d\/\Q${id}\E$/; + my $key = "pve-${type}-9.0/${id}"; + if (defined($rrd->{$key})) { + return $key; } } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel