From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 299DE1FF16F for ; Tue, 2 Sep 2025 14:45:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5800F12B87; Tue, 2 Sep 2025 14:45:59 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Tue, 2 Sep 2025 14:45:17 +0200 Message-ID: <20250902124524.368080-3-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250902124524.368080-1-m.sandoval@proxmox.com> References: <20250902124524.368080-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756817111311 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2 2/6] block job: mirror: follow guest-fsfreeze setting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This is used when performing a full-clone of a running VM. Signed-off-by: Maximiliano Sandoval --- src/PVE/QemuServer/BlockJob.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm index 633c0b34..b6e2d51f 100644 --- a/src/PVE/QemuServer/BlockJob.pm +++ b/src/PVE/QemuServer/BlockJob.pm @@ -162,8 +162,10 @@ sub qemu_drive_mirror_monitor { last if $completion eq 'skip' || $completion eq 'auto'; if ($vmiddst && $vmiddst != $vmid) { + my $config = PVE::QemuConfig->load_config($vmid); + my $fsfreeze = PVE::QemuServer::get_qga_key($config, 'guest-fsfreeze') // 1; my $agent_running = $qga && qga_check_running($vmid); - if ($agent_running) { + if ($agent_running && $fsfreeze) { print "freeze filesystem\n"; eval { mon_cmd($vmid, "guest-fsfreeze-freeze"); }; warn $@ if $@; @@ -176,7 +178,7 @@ sub qemu_drive_mirror_monitor { # if we clone a disk for a new target vm, we don't switch the disk qemu_blockjobs_cancel($vmid, $jobs); - if ($agent_running) { + if ($agent_running && $fsfreeze) { print "unfreeze filesystem\n"; eval { mon_cmd($vmid, "guest-fsfreeze-thaw"); }; warn $@ if $@; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel