From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1072F1FF183 for ; Wed, 27 Aug 2025 11:04:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E58F8146F7; Wed, 27 Aug 2025 11:04:48 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Date: Wed, 27 Aug 2025 11:04:31 +0200 Message-ID: <20250827090431.48707-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756285479790 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rrd.pm] Subject: [pve-devel] [PATCH pve-cluster v3] fix #6615: rrd: only return last entry if populated X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" RRD fetch can include the latest bucket before metrics are flushed, resulting in entries with only a timestamp. This now only returns the last entry if it contains at least one value. Signed-off-by: Hannes Laimer --- v3, thanks @Dominik: - only remove last entry if empty, not all empty ones src/PVE/RRD.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm index 8fe1927..5a23889 100644 --- a/src/PVE/RRD.pm +++ b/src/PVE/RRD.pm @@ -81,6 +81,12 @@ sub create_rrd_data { push @$res, $entry; } + # The newest bucket can still be empty right after a boundary. + if (@$res) { + # only contains 'time' + pop @$res if (scalar(keys %{$res->[-1]}) == 1); + } + return $res; } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel