From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9325D1FF183 for ; Wed, 13 Aug 2025 15:39:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2C48736877; Wed, 13 Aug 2025 15:41:03 +0200 (CEST) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Date: Wed, 13 Aug 2025 15:40:25 +0200 Message-ID: <20250813134028.292213-2-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250813134028.292213-1-m.carrara@proxmox.com> References: <20250813134028.292213-1-m.carrara@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755092398350 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-manager master v2 1/2] fix #6652: ceph: osd: enable autoactivation for OSD LVs on creation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" ... by adding an inline helper sub for `lvcreate` instead of using the LVM storage plugin's helper sub. Autoactivation is required for LVs used by Ceph OSDs, as Ceph otherwise doesn't activate them by itself. This is a regression from f296ffc4e4d in pve-storage [0]. [0]: https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=f296ffc4e4d64b574c3001dc7cc6af3da1406441 Fixes: #6652 Signed-off-by: Max R. Carrara --- PVE/API2/Ceph/OSD.pm | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index 23e187ce..0f850415 100644 --- a/PVE/API2/Ceph/OSD.pm +++ b/PVE/API2/Ceph/OSD.pm @@ -423,6 +423,29 @@ __PACKAGE__->register_method({ # See FIXME below my @udev_trigger_devs = (); + # $size is in kibibytes + my $osd_lvcreate = sub { + my ($vg, $lv, $size) = @_; + + my $cmd = [ + '/sbin/lvcreate', + '-aly', + '-Wy', + '--yes', + '--size', + $size . "k", + '--name', + $lv, + # explicitly enable autoactivation, because Ceph never explicitly + # activates LVs by itself + '--setautoactivation', + 'y', + $vg, + ]; + + run_command($cmd, errmsg => "lvcreate '$vg/$lv' error"); + }; + my $create_part_or_lv = sub { my ($dev, $size, $type) = @_; @@ -443,7 +466,7 @@ __PACKAGE__->register_method({ my $lv = $type . "-" . UUID::uuid(); PVE::Storage::LVMPlugin::lvm_create_volume_group($dev->{devpath}, $vg); - PVE::Storage::LVMPlugin::lvcreate($vg, $lv, "${size}k"); + $osd_lvcreate->($lv, $vg, $size); if (PVE::Diskmanage::is_partition($dev->{devpath})) { eval { PVE::Diskmanage::change_parttype($dev->{devpath}, '8E00'); }; @@ -475,7 +498,7 @@ __PACKAGE__->register_method({ my $lv = $type . "-" . UUID::uuid(); - PVE::Storage::LVMPlugin::lvcreate($vg, $lv, "${size}k"); + $osd_lvcreate->($vg, $lv, $size); return "$vg/$lv"; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel