From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E58F81FF16B for ; Tue, 12 Aug 2025 13:55:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44E9CBA35; Tue, 12 Aug 2025 13:57:28 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 12 Aug 2025 13:56:28 +0200 Message-ID: <20250812115652.79330-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754999785087 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [blockdev.pm, qmpclient.pm, monitor.pm] Subject: [pve-devel] [PATCH-SERIES qemu-server v2 0/3] qmp: improve error handling for mon_cmd() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Changes in v2: * use eval+warn around new detach() call sites, as failure should not be critical there. Add a new noerr argument to mon_cmd() to allow callers to opt-in to handling errors themselves. Without passing 'noerr' to mon_cmd(), errors are logged to the system journal. In the blockdev module, in attach() and detach(), there are two mon_cmd() calls that are expected to fail in some scenarios for which the errors should not be logged. Again in the blockdev module, the functions for deletion and replace had the same issue. Have them re-use the detach() function. Fiona Ebner (3): qmp client: add $noerr argument blockdev: attach/detach: silence errors for QMP commands for which failure may be expected blockdev: delete/replace: re-use detach() helper src/PVE/QMPClient.pm | 8 ++++--- src/PVE/QemuServer/Blockdev.pm | 16 ++++++-------- src/PVE/QemuServer/Monitor.pm | 40 +++++++++++++++++++++++++++++++--- 3 files changed, 49 insertions(+), 15 deletions(-) -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel