From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AFD551FF170 for ; Thu, 7 Aug 2025 11:52:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A76FA1911B; Thu, 7 Aug 2025 11:54:23 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Thu, 7 Aug 2025 11:54:12 +0200 Message-ID: <20250807095420.210040-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754560437406 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer] gui: remove G_SLICE=always-malloc usage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Since Glib 2.76 there is no need to set this environment variable as this is the default now. For more details see the release notes of 2.75.3 (pre-release for 2.76). Additionally, when run under Valgrind it would use malloc even from before 2.75.3. Proxmox VE 9 ships with libglib2.0 2.84. [1] https://gitlab.gnome.org/GNOME/glib/-/releases/2.75.3 Signed-off-by: Maximiliano Sandoval --- Makefile | 10 +++++----- proxinstall | 4 ---- xinitrc | 2 +- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile index 878c4bd..ad79925 100644 --- a/Makefile +++ b/Makefile @@ -182,12 +182,12 @@ cd-info.test: check-pve: prepare-check-env test.img rm -f cd-info.test; $(MAKE) cd-info.test ./proxmox-low-level-installer dump-env -t test.img - G_SLICE=always-malloc perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img + perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img check-pve-multidisks: prepare-check-env test.img test2.img test3.img test4.img test5.big.img rm -f cd-info.test; $(MAKE) cd-info.test ./proxmox-low-level-installer dump-env -t test.img,test2.img,test3.img,test4.img,test5.big.img - G_SLICE=always-malloc perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img,test2.img,test3.img,test4.img,test5.big.img + perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img,test2.img,test3.img,test4.img,test5.big.img check-pve-tui: prepare-check-env test.img rm -f cd-info.test; $(MAKE) cd-info.test @@ -208,7 +208,7 @@ prepare-check-pmg: prepare-check-env test.img ./proxmox-low-level-installer dump-env -t test.img check-pmg: prepare-check-pmg - G_SLICE=always-malloc perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img + perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img check-pmg-tui: prepare-check-pmg testdir/usr/bin/proxmox-tui-installer -t test.img 2>testdir/run/stderr @@ -222,7 +222,7 @@ prepare-check-pbs: prepare-check-env test.img ./proxmox-low-level-installer dump-env -t test.img check-pbs: prepare-check-pbs - G_SLICE=always-malloc perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img + perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img check-pbs-tui: prepare-check-pbs testdir/usr/bin/proxmox-tui-installer -t test.img 2>testdir/run/stderr @@ -236,7 +236,7 @@ prepare-check-pdm: prepare-check-env test.img ./proxmox-low-level-installer dump-env -t test.img check-pdm: prepare-check-pdm - G_SLICE=always-malloc perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img + perl -I testdir/usr/share/perl5 testdir/usr/bin/proxinstall -t test.img check-pdm-tui: prepare-check-pdm testdir/usr/bin/proxmox-tui-installer -t test.img 2>testdir/run/stderr diff --git a/proxinstall b/proxinstall index bf93b48..5ba65fa 100755 --- a/proxinstall +++ b/proxinstall @@ -40,10 +40,6 @@ use Proxmox::Sys::File qw(file_read_all file_write_all); use Proxmox::Sys::Net qw(parse_ip_address parse_ip_mask); use Proxmox::UI; -if (!$ENV{G_SLICE} || $ENV{G_SLICE} ne "always-malloc") { - die "do not use slice allocator (run with 'G_SLICE=always-malloc ./proxinstall ...')\n"; -} - my $step_number = 0; # Init number for global function list my @steps = ( diff --git a/xinitrc b/xinitrc index 5125406..02e67d9 100644 --- a/xinitrc +++ b/xinitrc @@ -4,4 +4,4 @@ /usr/bin/X11/xsetroot -solid grey openbox & /.spice-vdagent.sh & -G_SLICE=always-malloc /usr/bin/proxinstall +/usr/bin/proxinstall -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel