From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8F5CC1FF17C for ; Wed, 6 Aug 2025 10:28:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 138B535FE4; Wed, 6 Aug 2025 10:30:05 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 6 Aug 2025 10:28:15 +0200 Message-ID: <20250806082926.15848-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754468950130 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pve8to9.pm] Subject: [pve-devel] [PATCH manager] pve8to9: skip check for running guests if already upgraded X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" If already upgraded, the suggestion to stop or migrate running guests is wrong. Signed-off-by: Fiona Ebner --- PVE/CLI/pve8to9.pm | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index 994189f1..35785891 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -1985,22 +1985,26 @@ sub check_rrd_migration { sub check_virtual_guests { print_header("VIRTUAL GUEST CHECKS"); - log_info("Checking for running guests.."); - my $running_guests = 0; + if (!$upgraded) { + log_info("Checking for running guests.."); + my $running_guests = 0; - my $local_vms = eval { PVE::API2::Qemu->vmlist({ node => $nodename }) }; - log_warn("Failed to retrieve information about this node's VMs - $@") if $@; - $running_guests += grep { $_->{status} eq 'running' } @$local_vms if defined($local_vms); + my $local_vms = eval { PVE::API2::Qemu->vmlist({ node => $nodename }) }; + log_warn("Failed to retrieve information about this node's VMs - $@") if $@; + $running_guests += grep { $_->{status} eq 'running' } @$local_vms if defined($local_vms); - my $local_cts = eval { PVE::API2::LXC->vmlist({ node => $nodename }) }; - log_warn("Failed to retrieve information about this node's CTs - $@") if $@; - $running_guests += grep { $_->{status} eq 'running' } @$local_cts if defined($local_cts); + my $local_cts = eval { PVE::API2::LXC->vmlist({ node => $nodename }) }; + log_warn("Failed to retrieve information about this node's CTs - $@") if $@; + $running_guests += grep { $_->{status} eq 'running' } @$local_cts if defined($local_cts); - if ($running_guests > 0) { - log_warn( - "$running_guests running guest(s) detected - consider migrating or stopping them."); + if ($running_guests > 0) { + log_warn( + "$running_guests running guest(s) detected - consider migrating or stopping them."); + } else { + log_pass("no running guest detected."); + } } else { - log_pass("no running guest detected."); + log_skip("Skipping check for running guests - already upgraded."); } check_lxcfs_fuse_version(); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel