From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 386E21FF16F for ; Tue, 5 Aug 2025 13:33:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7CBB2D9B7; Tue, 5 Aug 2025 13:34:29 +0200 (CEST) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Tue, 5 Aug 2025 13:34:12 +0200 Message-Id: <20250805113412.119277-1-s.shaji@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754393646628 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.209 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [arec.data, brec.data] Subject: [pve-devel] [PATCH proxmox-backup] fix #6592: ui: add custom sort function to comment column X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" When sorting the Comment column, if the `comment` field was present, the sorting worked correctly. However, when the `comment` field was missing and only `last-comment` was available (and shown in the UI), the default Ext JS sorting did not use the `last-comment` value. To fix this, a custom sort function was added to use the `last-comment`` value when `comment` is empty. Signed-off-by: Shan Shaji --- www/datastore/Content.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/www/datastore/Content.js b/www/datastore/Content.js index 075022e9..a2aa1949 100644 --- a/www/datastore/Content.js +++ b/www/datastore/Content.js @@ -1004,6 +1004,15 @@ Ext.define('PBS.DataStoreContent', { return `${v} `; }, + sorter: (aRec, bRec) => { + let a = aRec.data.comment || aRec.data['last-comment'] || ''; + let b = bRec.data.comment || bRec.data['last-comment'] || ''; + + a = a.toLowerCase(); + b = b.toLowerCase(); + + return a.localeCompare(b); + }, listeners: { afterrender: function (component) { // a bit of a hack, but relatively easy, cheap and works out well. -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel