From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BD0F51FF180 for ; Fri, 1 Aug 2025 11:53:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 965A01545A; Fri, 1 Aug 2025 11:55:17 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Fri, 1 Aug 2025 11:54:29 +0200 Message-ID: <20250801095431.117317-3-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250801095431.117317-1-l.wagner@proxmox.com> References: <20250801095431.117317-1-l.wagner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754042070152 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH cluster 3/5] pmxcfs: status: call g_strdup instead of g_strdup_printf when no formatting is needed X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This should be a tiny bit more efficient. Signed-off-by: Lukas Wagner --- src/pmxcfs/status.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c index e438d9f..c8e072f 100644 --- a/src/pmxcfs/status.c +++ b/src/pmxcfs/status.c @@ -1371,7 +1371,7 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) { use_pve2_file = 1; g_free(filename); - filename = g_strdup_printf("%s", filename_pve2); + filename = g_strdup(filename_pve2); } else { // neither file exists, check for directories to decide and create file @@ -1383,7 +1383,7 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) { use_pve2_file = 1; g_free(filename); - filename = g_strdup_printf("%s", filename_pve2); + filename = g_strdup(filename_pve2); char *dir = g_path_get_dirname(filename); checked_mkdir(dir, 0755); @@ -1443,7 +1443,7 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) { // old file exists, use it use_pve2_file = 1; g_free(filename); - filename = g_strdup_printf("%s", filename_pve2); + filename = g_strdup(filename_pve2); } else { // neither file exists, check for directories to decide and create file @@ -1455,7 +1455,7 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) { use_pve2_file = 1; g_free(filename); - filename = g_strdup_printf("%s", filename_pve2); + filename = g_strdup(filename_pve2); int argcount = sizeof(rrd_def_vm) / sizeof(void *) - 1; create_rrd_file(filename, argcount, rrd_def_vm); @@ -1509,7 +1509,7 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) { } else if (g_file_test(filename_pve2, G_FILE_TEST_EXISTS)) { // old file exists, use it g_free(filename); - filename = g_strdup_printf("%s", filename_pve2); + filename = g_strdup(filename_pve2); } else { // neither file exists, check for directories to decide and create file @@ -1522,7 +1522,7 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) { create_rrd_file(filename, argcount, rrd_def_storage_pve9_0); } else if (g_file_test(RRDDIR "/pve2-storage", G_FILE_TEST_IS_DIR)) { g_free(filename); - filename = g_strdup_printf("%s", filename_pve2); + filename = g_strdup(filename_pve2); char *dir = g_path_get_dirname(filename); checked_mkdir(dir, 0755); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel