From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 50BDF1FF183 for ; Wed, 30 Jul 2025 18:20:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7ADF01490B; Wed, 30 Jul 2025 18:21:53 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Jul 2025 18:20:55 +0200 Message-ID: <20250730162117.160498-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250730162117.160498-1-f.ebner@proxmox.com> References: <20250730162117.160498-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753892469581 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmplugin.pm] Subject: [pve-devel] [PATCH storage 1/3] lvm plugin: snapshot info: avoid superfluous argument for closure X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The $volname variable is never modified in the function, so it doesn't need to be passed into the $get_snapname_from_path closure. Signed-off-by: Fiona Ebner --- src/PVE/Storage/LVMPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 67fcfbd..705585f 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -800,7 +800,7 @@ sub volume_snapshot_info { my ($class, $scfg, $storeid, $volname) = @_; my $get_snapname_from_path = sub { - my ($volname, $path) = @_; + my ($path) = @_; my $name = basename($path); if (my $snapname = parse_snap_name($name)) { @@ -829,7 +829,7 @@ sub volume_snapshot_info { my $snapshots = $json_decode; for my $snap (@$snapshots) { my $snapfile = $snap->{filename}; - my $snapname = $get_snapname_from_path->($volname, $snapfile); + my $snapname = $get_snapname_from_path->($snapfile); #not a proxmox snapshot next if !$snapname; @@ -842,7 +842,7 @@ sub volume_snapshot_info { my $parentfile = $snap->{'backing-filename'}; if ($parentfile) { - my $parentname = $get_snapname_from_path->($volname, $parentfile); + my $parentname = $get_snapname_from_path->($parentfile); $info->{$snapname}->{parent} = $parentname; $info->{$parentname}->{child} = $snapname; } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel