From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D12351FF183 for ; Wed, 30 Jul 2025 17:02:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 596C612774; Wed, 30 Jul 2025 17:03:31 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Jul 2025 17:03:14 +0200 Message-ID: <20250730150325.138087-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753887798162 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES qemu-server 0/3] image convert: fix handling qcow2 on snapshot-as-volume-chain dir target X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" As reported by Friedrich, having qcow2 on a snapshot-as-volume-chain directory storage be the target would fail with: > Block format 'qcow2' does not support the option 'zeroinit:driver' First patch is to work around this by just not specifying zeroinit which leads to a performance penalty. Following patches would fix the issue by actually using the zeroinit driver, and we meet and old friend again with 2/3 :P (patch was proposed once before already). Fiona Ebner (3): image convert: avoid combining target image options and zeroinit filter image convert: re-use generate_drive_blockdev() image convert: make using zeroinit with target-image-opts work src/PVE/QemuServer/QemuImage.pm | 77 ++++++++++++++++++++++---- src/test/run_qemu_img_convert_tests.pl | 47 +++++++++++++--- 2 files changed, 107 insertions(+), 17 deletions(-) -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel