From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 127BB1FF183 for ; Wed, 30 Jul 2025 14:33:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B58E1C8FF; Wed, 30 Jul 2025 14:34:57 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Wed, 30 Jul 2025 14:34:45 +0200 Message-ID: <20250730123447.89001-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753878883313 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.013 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm] Subject: [pve-devel] [PATCH container] config: remove apply_pending_device_passthrough helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This simplifies the code and avoids unnecessary parsing and re-serializing of the identical device passthrough object. Signed-off-by: Filip Schauer --- src/PVE/LXC/Config.pm | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index de963bc..5d7edc4 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1618,8 +1618,8 @@ sub vmconfig_hotplug_pending { die "skip\n"; # don't try to hotplug over existing dev } - $class->apply_pending_device_passthrough($vmid, $conf, $opt, 1); - $value = $conf->{pending}->{$opt}; + my $dev = $class->parse_device($value); + PVE::LXC::device_passthrough_hotplug($vmid, $conf, $dev); } else { die "skip\n"; # skip non-hotpluggable } @@ -1739,18 +1739,6 @@ my $rescan_volume = sub { warn "Could not rescan volume size - $@\n" if $@; }; -sub apply_pending_device_passthrough { - my ($class, $vmid, $conf, $opt, $running) = @_; - - my $dev = $class->parse_device($conf->{pending}->{$opt}); - my $old = $conf->{$opt}; - if ($running) { - die "skip\n" if defined($old); # TODO: editing a device passthrough - PVE::LXC::device_passthrough_hotplug($vmid, $conf, $dev); - $conf->{pending}->{$opt} = $class->print_device($dev); - } -} - sub apply_pending_mountpoint { my ($class, $vmid, $conf, $opt, $storecfg, $running) = @_; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel