From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 65D7F1FF15F for ; Sat, 26 Jul 2025 03:11:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0768F324D5; Sat, 26 Jul 2025 03:12:30 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Sat, 26 Jul 2025 03:06:18 +0200 Message-Id: <20250726010626.1496866-24-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726010626.1496866-1-a.lauterer@proxmox.com> References: <20250726010626.1496866-1-a.lauterer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753491982335 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v4 14/15] d/postinst: run promox-rrd-migration-tool X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Aaron Lauterer --- Notes: currently it checks for lt 9.0.0~12. should it only be applied to a later version, don't forget to adapt the version check! I tested it by bumping the version to 9.0.0~12 upgraded to it -> migration ran reinstalled -> no migration happening when installing the bumped pve-manager package and the proxmox-rrd-migration-tool package at the same time, dependencies are resolved and the postinst script works. There is still one bug though that happens on my live system: While the migration tool moves the processed files to FILE.old, new ones without the .old are still present. I did a quick try, disabling rrdached before we call the migration tool. But that didn't help. Could be that pmxcfs is receiving new data and is recreating them. Or maybe something else. That would need to be debugged to figure out as apparently I did miss something here regarding the behavior. debian/postinst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/debian/postinst b/debian/postinst index a0480b24..b15603ac 100755 --- a/debian/postinst +++ b/debian/postinst @@ -227,6 +227,11 @@ case "$1" in migrate_apt_auth_conf fi fi + + if test -n "$2" && dpkg --compare-versions "$2" 'lt' '9.0.0~12'; then + echo "migradting RRD to new PVE format version - this can take some time!" + proxmox-rrd-migration-tool --migrate || echo "migration failed, see output above for errors and try to migrate existing data manually by running 'proxmox-rrd-migration-tool --migrate'" + fi ;; abort-upgrade|abort-remove|abort-deconfigure) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel