From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 345DA1FF15F for ; Sat, 26 Jul 2025 03:07:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2039331F1E; Sat, 26 Jul 2025 03:07:12 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Sat, 26 Jul 2025 03:06:09 +0200 Message-Id: <20250726010626.1496866-15-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250726010626.1496866-1-a.lauterer@proxmox.com> References: <20250726010626.1496866-1-a.lauterer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753491982248 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v4 05/15] ui: node summary: use stacked memory graph with zfs arc X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" To display the used memory and the ZFS arc as a separate data point, keeping the old line overlapping filled line graphs won't work anymore. We therefore switch them to area graphs which are stacked by default. The order of the fields is important here as it affects the order in the stacking. This means we also need to override colors manually to keep them in line as it used to be. Additionally, we don't use the 3rd color in the default extjs color scheme, as that would be dark red [0]. We go with a color that is different enough and not associated as a warning or error: dark-grey. [0] https://docs.sencha.com/extjs/7.0.0/classic/src/Base.js-6.html#line318 Signed-off-by: Aaron Lauterer Reviewed-by: Dominik Csapak --- www/manager6/node/Summary.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js index c9d73494..ed3d33d9 100644 --- a/www/manager6/node/Summary.js +++ b/www/manager6/node/Summary.js @@ -177,11 +177,18 @@ Ext.define('PVE.node.Summary', { { xtype: 'proxmoxRRDChart', title: gettext('Memory usage'), - fields: ['memtotal', 'memused'], - fieldTitles: [gettext('Total'), gettext('RAM usage')], + fields: [ + { + type: 'area', + yField: ['memused-sub-arcsize', 'arcsize', 'memfree-capped'], + title: [gettext('Used'), gettext('ZFS'), gettext('Free')], + }, + ], + colors: ['#115fa6', '#7c7474', '#94ae0a'], unit: 'bytes', powerOfTwo: true, store: rrdstore, + stacked: true, }, { xtype: 'proxmoxRRDChart', -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel