From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BA2501FF15C for ; Fri, 25 Jul 2025 12:50:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 309BC158F4; Fri, 25 Jul 2025 12:51:46 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 25 Jul 2025 12:50:54 +0200 Message-ID: <20250725105109.54093-8-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250725105109.54093-1-f.ebner@proxmox.com> References: <20250725105109.54093-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753440669292 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2 7/8] tests: cfg2cmd: improve mocking File::stat X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Stat-ing /dev/null worked, because the check in the blockdev module is for block and character devices and then decides based on the 'media=cdrom' flag whether to use the host_cdrom or host_device driver. But the result should actually be mocked to represent a block device rather than a character device. Signed-off-by: Fiona Ebner --- New in v2. src/test/run_config2command_tests.pl | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/test/run_config2command_tests.pl b/src/test/run_config2command_tests.pl index 7156c2e9..0623b5c1 100755 --- a/src/test/run_config2command_tests.pl +++ b/src/test/run_config2command_tests.pl @@ -317,11 +317,9 @@ my $file_stat_module = Test::MockModule->new("File::stat"); $file_stat_module->mock( stat => sub { my ($path) = @_; - if ($path =~ m!/dev/!) { - return $file_stat_module->original('stat')->('/dev/null'); - } else { - return $file_stat_module->original('stat')->('./run_config2command_tests.pl'); - } + my $st = $file_stat_module->original('stat')->('./run_config2command_tests.pl'); + $st->[2] = 25008 if $path =~ m!/dev/!; # block device + return $st; }, ); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel