From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8595D1FF16F for ; Tue, 22 Jul 2025 11:31:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 802193462C; Tue, 22 Jul 2025 11:32:45 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 22 Jul 2025 11:30:34 +0200 Message-ID: <20250722093238.24988-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250722093238.24988-1-f.ebner@proxmox.com> References: <20250722093238.24988-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753176753619 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server 2/2] qmp: device unplug: bump timeout for removing virtio scsi controller X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" It's possible to run into the default timeout of 5 seconds with quite a simple and generic Debian 12, kernel 6.1 test VM. Detaching happened right after doing a lot of IO on the associated drive. In testing, detaching the drive itself was immediate, and detaching the VirtIO SCSI controller always took 6 seconds. Use 15 seconds, so that it's more than twice the value to be on the safe side for the future. For completeness, the VM configuration: agent: 0 boot: order=scsi0 cores: 2 cpu: host hotplug: disk,network,usb ide2: none,media=cdrom machine: q35 memory: 6144 name: Copy-of-VM-Copy-of-VM-apache net0: virtio=BC:24:11:49:0F:85,bridge=vnet0,firewall=1 numa: 1 ostype: l26 scsi0: sharedlvm:vm-103-disk-0.qcow2,iothread=1,size=4304M scsi1: sharedlvm:vm-103-disk-1.qcow2,iothread=1,size=4G scsi2: sharedlvm:vm-103-disk-2.qcow2,iothread=1,size=4G scsi3: zfs:vm-103-disk-0,size=4G scsihw: virtio-scsi-single smbios1: uuid=f3f9952f-aab9-45ef-933d-ee01df474b26 sockets: 2 startup: order=2 vmgenid: 529f6974-6fc8-4196-9fb2-9639f55d31d6 Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 9f327955..67b86ff4 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -4011,7 +4011,7 @@ sub vm_deviceunplug { qemu_iothread_del($vmid, $deviceid, $device); } elsif ($deviceid =~ m/^(virtioscsi|scsihw)(\d+)$/) { qemu_devicedel($vmid, $deviceid); - qemu_devicedelverify($vmid, $deviceid); + qemu_devicedelverify($vmid, $deviceid, 15); } elsif ($deviceid =~ m/^(scsi)(\d+)$/) { my $device = parse_drive($deviceid, $conf->{$deviceid}); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel